add service validation

Author: shaowei su

pkg/cert-generator/v1beta1/generate/generate.go

@@ -68,6 +68,12 @@ func NewGenerateCmd(kubeClient client.Client) *cobra.Command {
 
 // run is main function for `generate` subcommand.
 func (o *generateOptions) run(ctx context.Context, kubeClient client.Client) error {
+	controllerService := &corev1.Service{}
+	if err := kubeClient.Get(ctx, client.ObjectKey{Namespace: o.namespace, Name: o.serviceName}, controllerService); err != nil {
+		klog.Errorf("Unable to locate controller service: %s", o.serviceName)
+		return err
+	}
+
 	o.fullServiceDomain = strings.Join([]string{o.serviceName, o.namespace, "svc"}, ".")
 
 	caKeyPair, err := o.createCACert()

pkg/cert-generator/v1beta1/generate/generate_test.go

@@ -85,7 +85,6 @@ func TestGenerate(t *testing.T) {
 			},
 		},
 	}
-
 	oldWebhookCertSecret := &corev1.Secret{
 		TypeMeta: metav1.TypeMeta{
 			Kind:       "Secret",
@@ -96,6 +95,16 @@ func TestGenerate(t *testing.T) {
 			Namespace: testNamespace,
 		},
 	}
+	testControllerService := &corev1.Service{
+		TypeMeta: metav1.TypeMeta{
+			Kind:       "Service",
+			APIVersion: "v1",
+		},
+		ObjectMeta: metav1.ObjectMeta{
+			Name:      consts.Service,
+			Namespace: testNamespace,
+		},
+	}
 
 	tests := []struct {
 		testDescription string
@@ -109,6 +118,7 @@ func TestGenerate(t *testing.T) {
 				testGeneratorJob,
 				testValidatingWebhook,
 				testMutatingWebhook,
+				testControllerService,
 			},
 		},
 		{
@@ -119,6 +129,7 @@ func TestGenerate(t *testing.T) {
 				testValidatingWebhook,
 				testMutatingWebhook,
 				oldWebhookCertSecret,
+				testControllerService,
 			},
 		},
 		{
@@ -127,6 +138,7 @@ func TestGenerate(t *testing.T) {
 			objects: []client.Object{
 				testValidatingWebhook,
 				testMutatingWebhook,
+				testControllerService,
 			},
 		},
 		{
@@ -135,6 +147,7 @@ func TestGenerate(t *testing.T) {
 			objects: []client.Object{
 				testGeneratorJob,
 				testMutatingWebhook,
+				testControllerService,
 			},
 		},
 		{
@@ -143,6 +156,15 @@ func TestGenerate(t *testing.T) {
 			objects: []client.Object{
 				testGeneratorJob,
 				testValidatingWebhook,
+				testControllerService,
+			},
+		},
+		{
+			testDescription: "There is no Service katib-controller",
+			err:             true,
+			objects: []client.Object{
+				testGeneratorJob,
+				testMutatingWebhook,
 			},
 		},
 	}