Skip to content

Commit 2a71e3f

Browse files
committed
Fixing code review items
1 parent 08f3768 commit 2a71e3f

File tree

16 files changed

+19
-44
lines changed

16 files changed

+19
-44
lines changed

operators/OWNERS

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
11
approvers:
22
- knkski
33
- rfmvasconcelos
4-
5-
reviewers:

operators/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,11 @@
44
This bundle encompasses the Kubernetes python operators (a.k.a. charms) for Katib
55
(see [CharmHub](https://charmhub.io/?q=katib)).
66

7-
The Katib operators are python scripts that wrap the latest [Katib manifests](manifests),
7+
The Katib operators are python scripts that wrap the latest released [Katib manifests][manifests],
88
providing lifecycle management for each application, handling events (install, upgrade,
99
integrate, remove).
1010

11-
[manifests]: https://github.com/kubeflow/manifests/tree/master/katib
11+
[manifests]: https://github.com/kubeflow/katib/tree/master/manifests
1212

1313
## Install
1414

operators/bundle.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ bundle: kubernetes
22
applications:
33
katib-controller: { charm: katib-controller, scale: 1, annotations: { gui-x: '0', gui-y: '0' } }
44
katib-db: { charm: cs:~charmed-osm/mariadb-k8s, scale: 1, annotations: { gui-x: '0', gui-y: '300' }, options: { database: katib } }
5-
katib-manager: { charm: katib-manager, scale: 1, annotations: { gui-x: '300', gui-y: '0' } }
5+
katib-db-manager: { charm: katib-db-manager, scale: 1, annotations: { gui-x: '300', gui-y: '0' } }
66
katib-ui: { charm: katib-ui, scale: 1, annotations: { gui-x: '300', gui-y: '300' } }
77
relations:
8-
- [katib-manager, katib-db]
8+
- [katib-db-manager, katib-db]

operators/katib-controller/config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ options:
66
metrics-port:
77
type: int
88
default: 8080
9-
description: Webhook port
9+
description: Metrics port
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.

operators/katib-controller/metadata.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ resources:
1515
type: oci-image
1616
description: Backing OCI image
1717
auto-fetch: true
18-
upstream-source: docker.io/kubeflowkatib/katib-controller:v1beta1-7104018
18+
upstream-source: docker.io/kubeflowkatib/katib-controller:v1beta1-a96ff59
1919
provides:
2020
katib-controller:
2121
interface: http

0 commit comments

Comments
 (0)