Skip to content

Commit 0e35f07

Browse files
committed
implement gRPC API to verify parameters for early stopping
1 parent a9322f8 commit 0e35f07

File tree

15 files changed

+865
-149
lines changed

15 files changed

+865
-149
lines changed

pkg/apis/manager/v1beta1/api.pb.go

Lines changed: 188 additions & 118 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pkg/apis/manager/v1beta1/api.proto

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ service Suggestion {
4242
service EarlyStopping {
4343
rpc GetEarlyStoppingRules(GetEarlyStoppingRulesRequest) returns (GetEarlyStoppingRulesReply);
4444
rpc SetTrialStatus(SetTrialStatusRequest) returns (SetTrialStatusReply);
45+
rpc ValidateEarlyStoppingSettings(ValidateEarlyStoppingSettingsRequest) returns (ValidateEarlyStoppingSettingsReply);
4546
}
4647

4748
/**
@@ -339,6 +340,16 @@ message EarlyStoppingRule {
339340
int32 start_step = 4;
340341
}
341342

343+
message ValidateEarlyStoppingSettingsRequest {
344+
EarlyStoppingSpec early_stopping_spec = 1;
345+
}
346+
347+
/**
348+
* Return INVALID_ARGUMENT Error if Early Stopping Settings are not Valid
349+
*/
350+
message ValidateEarlyStoppingSettingsReply {
351+
}
352+
342353
enum ComparisonType {
343354
UNKNOWN_COMPARISON = 0; // Unknown comparison, not used
344355
EQUAL = 1; // Equal comparison, e.g. accuracy = 0.7

pkg/apis/manager/v1beta1/gen-doc/api.md

Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@
4444
- [TrialStatus](#api.v1.beta1.TrialStatus)
4545
- [ValidateAlgorithmSettingsReply](#api.v1.beta1.ValidateAlgorithmSettingsReply)
4646
- [ValidateAlgorithmSettingsRequest](#api.v1.beta1.ValidateAlgorithmSettingsRequest)
47+
- [ValidateEarlyStoppingSettingsReply](#api.v1.beta1.ValidateEarlyStoppingSettingsReply)
48+
- [ValidateEarlyStoppingSettingsRequest](#api.v1.beta1.ValidateEarlyStoppingSettingsRequest)
4749

4850
- [ComparisonType](#api.v1.beta1.ComparisonType)
4951
- [ObjectiveType](#api.v1.beta1.ObjectiveType)
@@ -696,6 +698,31 @@ Return INVALID_ARGUMENT Error if Algorithm Settings are not Valid
696698

697699

698700

701+
702+
<a name="api.v1.beta1.ValidateEarlyStoppingSettingsReply"></a>
703+
704+
### ValidateEarlyStoppingSettingsReply
705+
Return INVALID_ARGUMENT Error if Early Stopping Settings are not Valid
706+
707+
708+
709+
710+
711+
712+
<a name="api.v1.beta1.ValidateEarlyStoppingSettingsRequest"></a>
713+
714+
### ValidateEarlyStoppingSettingsRequest
715+
716+
717+
718+
| Field | Type | Label | Description |
719+
| ----- | ---- | ----- | ----------- |
720+
| early_stopping_spec | [EarlyStoppingSpec](#api.v1.beta1.EarlyStoppingSpec) | | |
721+
722+
723+
724+
725+
699726

700727

701728

@@ -784,6 +811,7 @@ EarlyStopping service defines APIs to manage Katib Early Stopping algorithms
784811
| ----------- | ------------ | ------------- | ------------|
785812
| GetEarlyStoppingRules | [GetEarlyStoppingRulesRequest](#api.v1.beta1.GetEarlyStoppingRulesRequest) | [GetEarlyStoppingRulesReply](#api.v1.beta1.GetEarlyStoppingRulesReply) | |
786813
| SetTrialStatus | [SetTrialStatusRequest](#api.v1.beta1.SetTrialStatusRequest) | [SetTrialStatusReply](#api.v1.beta1.SetTrialStatusReply) | |
814+
| ValidateEarlyStoppingSettings | [ValidateEarlyStoppingSettingsRequest](#api.v1.beta1.ValidateEarlyStoppingSettingsRequest) | [ValidateEarlyStoppingSettingsReply](#api.v1.beta1.ValidateEarlyStoppingSettingsReply) | |
787815

788816

789817
<a name="api.v1.beta1.Suggestion"></a>

pkg/apis/manager/v1beta1/gen-doc/index.html

Lines changed: 46 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -338,6 +338,14 @@ <h2>Table of Contents</h2>
338338
<a href="#api.v1.beta1.ValidateAlgorithmSettingsRequest"><span class="badge">M</span>ValidateAlgorithmSettingsRequest</a>
339339
</li>
340340

341+
<li>
342+
<a href="#api.v1.beta1.ValidateEarlyStoppingSettingsReply"><span class="badge">M</span>ValidateEarlyStoppingSettingsReply</a>
343+
</li>
344+
345+
<li>
346+
<a href="#api.v1.beta1.ValidateEarlyStoppingSettingsRequest"><span class="badge">M</span>ValidateEarlyStoppingSettingsRequest</a>
347+
</li>
348+
341349

342350
<li>
343351
<a href="#api.v1.beta1.ComparisonType"><span class="badge">E</span>ComparisonType</a>
@@ -1630,6 +1638,37 @@ <h3 id="api.v1.beta1.ValidateAlgorithmSettingsRequest">ValidateAlgorithmSettings
16301638

16311639

16321640

1641+
<h3 id="api.v1.beta1.ValidateEarlyStoppingSettingsReply">ValidateEarlyStoppingSettingsReply</h3>
1642+
<p>Return INVALID_ARGUMENT Error if Early Stopping Settings are not Valid</p>
1643+
1644+
1645+
1646+
1647+
1648+
<h3 id="api.v1.beta1.ValidateEarlyStoppingSettingsRequest">ValidateEarlyStoppingSettingsRequest</h3>
1649+
<p></p>
1650+
1651+
1652+
<table class="field-table">
1653+
<thead>
1654+
<tr><td>Field</td><td>Type</td><td>Label</td><td>Description</td></tr>
1655+
</thead>
1656+
<tbody>
1657+
1658+
<tr>
1659+
<td>early_stopping_spec</td>
1660+
<td><a href="#api.v1.beta1.EarlyStoppingSpec">EarlyStoppingSpec</a></td>
1661+
<td></td>
1662+
<td><p> </p></td>
1663+
</tr>
1664+
1665+
</tbody>
1666+
</table>
1667+
1668+
1669+
1670+
1671+
16331672

16341673

16351674
<h3 id="api.v1.beta1.ComparisonType">ComparisonType</h3>
@@ -1852,6 +1891,13 @@ <h3 id="api.v1.beta1.EarlyStopping">EarlyStopping</h3>
18521891
<td><p></p></td>
18531892
</tr>
18541893

1894+
<tr>
1895+
<td>ValidateEarlyStoppingSettings</td>
1896+
<td><a href="#api.v1.beta1.ValidateEarlyStoppingSettingsRequest">ValidateEarlyStoppingSettingsRequest</a></td>
1897+
<td><a href="#api.v1.beta1.ValidateEarlyStoppingSettingsReply">ValidateEarlyStoppingSettingsReply</a></td>
1898+
<td><p></p></td>
1899+
</tr>
1900+
18551901
</tbody>
18561902
</table>
18571903

0 commit comments

Comments
 (0)