Modify n_EI_candidates in Hyperopt

Author: andreyvelich

pkg/suggestion/v1beta1/hyperopt/service.py

@@ -69,7 +69,7 @@ class OptimizerConfiguration:
         'tpe': {
             'gamma': lambda x: float(x),
             'prior_weight': lambda x: float(x),
-            'n_EI_candidates': lambda x: int(x),
+            'n_ei_candidates': lambda x: int(x),
             "random_state": lambda x: int(x),
         },
         "random": {
@@ -107,9 +107,9 @@ def _validate_tpe_setting(cls, algorithm_settings):
                 elif s.name == 'prior_weight':
                     if not float(s.value) > 0:
                         return False, "prior_weight should be great than zero"
-                elif s.name == 'n_EI_candidates':
+                elif s.name == 'n_ei_candidates':
                     if not int(s.value) > 0:
-                        return False, "n_EI_candidates should be great than zero"
+                        return False, "n_ei_candidates should be great than zero"
                 elif s.name == 'random_state':
                     if not int(s.value) >= 0:
                         return False, "random_state should be great or equal than zero"

test/suggestion/v1beta1/test_hyperopt_service.py

@@ -143,7 +143,7 @@ def test_get_suggestion(self):
                             value="1.0"
                         ),
                         api_pb2.AlgorithmSetting(
-                            name="n_EI_candidates",
+                            name="n_ei_candidates",
                             value="24"
                         ),
                     ],
@@ -220,7 +220,7 @@ def test_validate_algorithm_settings(self):
                         value="1.0"
                     ),
                     api_pb2.AlgorithmSetting(
-                        name="n_EI_candidates",
+                        name="n_ei_candidates",
                         value="24"
                     ),
                 ]
@@ -270,19 +270,19 @@ def test_validate_algorithm_settings(self):
         self.assertEqual(code, grpc.StatusCode.INVALID_ARGUMENT)
         self.assertEqual(details, "gamma should be in the range of (0, 1)")
 
-        # Invalid n_EI_candidates value.
+        # Invalid n_ei_candidates value.
         experiment_spec = api_pb2.ExperimentSpec(
             algorithm=api_pb2.AlgorithmSpec(
                 algorithm_name="tpe",
                 algorithm_settings=[
-                    api_pb2.AlgorithmSetting(name="n_EI_candidates", value="0")
+                    api_pb2.AlgorithmSetting(name="n_ei_candidates", value="0")
                 ]
             )
         )
 
         _, _, code, details = utils.call_validate(self.test_server, experiment_spec)
         self.assertEqual(code, grpc.StatusCode.INVALID_ARGUMENT)
-        self.assertEqual(details, "n_EI_candidates should be great than zero")
+        self.assertEqual(details, "n_ei_candidates should be great than zero")
 
         # Invalid random_state value.
         experiment_spec = api_pb2.ExperimentSpec(