Skip to content

Commit cc9f81f

Browse files
committed
remove onDocumentSaved support
Signed-off-by: Scott J Dickerson <[email protected]>
1 parent f9dfd02 commit cc9f81f

File tree

3 files changed

+9
-21
lines changed

3 files changed

+9
-21
lines changed

client/src/app/components/schema-defined-fields/SchemaAsCodeEditor.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export interface ISchemaAsCodeEditorProps {
2424
id: string;
2525
jsonDocument: object;
2626
jsonSchema?: JsonSchemaObject;
27-
onDocumentSaved?: (newSchemaContent: object) => void;
2827
onDocumentChanged?: (newSchemaContent: object) => void;
2928
isReadOnly?: boolean;
3029
/**
@@ -38,7 +37,6 @@ export const SchemaAsCodeEditor = ({
3837
id,
3938
jsonDocument,
4039
jsonSchema,
41-
onDocumentSaved,
4240
onDocumentChanged,
4341
isReadOnly = false,
4442
height = "600px",
@@ -48,7 +46,7 @@ export const SchemaAsCodeEditor = ({
4846
const [currentCode, setCurrentCode] = React.useState(
4947
JSON.stringify(jsonDocument, null, 2)
5048
);
51-
const [okToSave, setOkToSave] = React.useState(true);
49+
// const [documentIsValid, setDocumentIsValid] = React.useState(true);
5250

5351
const focusMovedOnSelectedDocumentChange = React.useRef<boolean>(false);
5452
React.useEffect(() => {
@@ -61,7 +59,7 @@ export const SchemaAsCodeEditor = ({
6159
const focusAndHomePosition = () => {
6260
if (editorRef.current) {
6361
editorRef.current.focus();
64-
editorRef.current.setPosition({ column: 0, lineNumber: 1 });
62+
editorRef.current.setPosition({ column: 1, lineNumber: 1 });
6563
}
6664
};
6765

@@ -113,11 +111,13 @@ export const SchemaAsCodeEditor = ({
113111
});
114112
}
115113
}}
116-
editorProps={{
117-
onValidate: (markers) => {
118-
setOkToSave(markers.every(({ severity }) => severity !== 8));
119-
},
120-
}}
114+
// editorProps={{
115+
// onValidate: (markers) => {
116+
// setDocumentIsValid(
117+
// markers.every(({ severity }) => severity !== MarkerSeverity.Error)
118+
// );
119+
// },
120+
// }}
121121
showEditor={!!currentCode}
122122
emptyState={
123123
<div className="simple-task-viewer-empty-state">

client/src/app/components/schema-defined-fields/SchemaAsFields.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ export interface SchemaAsFieldsProps {
2020
id: string;
2121
jsonDocument: object;
2222
jsonSchema: JsonSchemaObject;
23-
onDocumentSaved?: (newJsonDocument: object) => void;
2423
onDocumentChanged?: (newJsonDocument: object) => void;
2524
isReadOnly?: boolean;
2625
}
@@ -222,7 +221,6 @@ export const SchemaAsFields: React.FC<SchemaAsFieldsProps> = ({
222221
jsonDocument,
223222
jsonSchema,
224223
onDocumentChanged,
225-
// Note: onDocumentSaved doesn't make sense for this component
226224
isReadOnly = false,
227225
}) => {
228226
const { t } = useTranslation();

client/src/app/components/schema-defined-fields/SchemaDefinedFields.tsx

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ export interface ISchemaDefinedFieldProps {
1212
className?: string;
1313
jsonDocument: object;
1414
jsonSchema?: JsonSchemaObject;
15-
onDocumentSaved?: (newJsonDocument: object) => void;
1615
onDocumentChanged?: (newJsonDocument: object) => void;
1716
isReadOnly?: boolean;
1817
}
@@ -22,20 +21,13 @@ export const SchemaDefinedField = ({
2221
className,
2322
jsonDocument,
2423
jsonSchema,
25-
onDocumentSaved,
2624
onDocumentChanged,
2725
isReadOnly = false,
2826
}: ISchemaDefinedFieldProps) => {
2927
const [isJsonView, setIsJsonView] = React.useState<boolean>(
3028
!jsonSchema || isComplexSchema(jsonSchema)
3129
);
3230

33-
const onSavedHandler = !onDocumentSaved
34-
? undefined
35-
: (newJsonDocument: object) => {
36-
onDocumentSaved?.(newJsonDocument);
37-
};
38-
3931
const onChangeHandler = (newJsonDocument: object) => {
4032
onDocumentChanged?.(newJsonDocument);
4133
};
@@ -66,7 +58,6 @@ export const SchemaDefinedField = ({
6658
isReadOnly={isReadOnly}
6759
jsonDocument={jsonDocument}
6860
jsonSchema={jsonSchema}
69-
onDocumentSaved={onSavedHandler}
7061
onDocumentChanged={onChangeHandler}
7162
/>
7263
) : (
@@ -75,7 +66,6 @@ export const SchemaDefinedField = ({
7566
isReadOnly={isReadOnly}
7667
jsonDocument={jsonDocument}
7768
jsonSchema={jsonSchema}
78-
onDocumentSaved={onSavedHandler}
7969
onDocumentChanged={onChangeHandler}
8070
/>
8171
)}

0 commit comments

Comments
 (0)