A port of Blender's AgX to darktable (darktable-org#19026)

* A port of Blender's AgX to darktable

---------

Co-authored-by: Anna <[email protected]>

Author: kofa73

.gitignore

@@ -25,3 +25,5 @@ output*png
 Brewfile.lock.json
 CMakeLists.txt.user
 workspace/
+cmake-build-debug/
+.idea/

data/darktableconfig.xml.in

@@ -3562,6 +3562,7 @@
       <enum>
         <option>scene-referred (sigmoid)</option>
         <option>scene-referred (filmic)</option>
+        <option>scene-referred (agx)</option>
         <option>display-referred (legacy)</option>
         <option>none</option>
       </enum>
@@ -3900,6 +3901,41 @@
     <shortdescription>active tab in tone equaliser module</shortdescription>
     <longdescription>which of simple, advanced or masking tabs will show at startup</longdescription>
   </dtconfig>
+  <dtconfig>
+    <name>plugins/darkroom/agx/enable_curve_tab</name>
+    <type>bool</type>
+    <default>false</default>
+    <shortdescription>whether to enable the curve tab</shortdescription>
+    <longdescription>if enabled, the settings tab will have fewer controls and will occupy less vertical space</longdescription>
+  </dtconfig>
+  <dtconfig>
+    <name>plugins/darkroom/agx/look_always_visible</name>
+    <type>bool</type>
+    <default>false</default>
+    <shortdescription>whether to keep look controls always visible</shortdescription>
+    <longdescription>if enabled, the look controls won't be placed in a collapsible section</longdescription>
+  </dtconfig>
+  <dtconfig>
+    <name>plugins/darkroom/agx/expand_curve_graph</name>
+    <type>bool</type>
+    <default>false</default>
+    <shortdescription>whether to expand the curve graph</shortdescription>
+    <longdescription>this is just to store whether to show the curve graph or not</longdescription>
+  </dtconfig>
+  <dtconfig>
+    <name>plugins/darkroom/agx/curve_graph_height</name>
+    <type min="100" max="300">int</type>
+    <default>200</default>
+    <shortdescription>height of agx graph in per cent</shortdescription>
+    <longdescription>height of agx graph in per cent</longdescription>
+  </dtconfig>
+  <dtconfig>
+    <name>plugins/darkroom/agx/expand_curve_advanced</name>
+    <type>bool</type>
+    <default>false</default>
+    <shortdescription>whether to show advanced curve parameters</shortdescription>
+    <longdescription>this is just to store whether to show advanced curve parameters or not</longdescription>
+  </dtconfig>
   <dtconfig>
     <name>plugins/lighttable/collect/windowheight</name>
     <type>int</type>

src/common/iop_order.c

@@ -140,6 +140,7 @@ const dt_iop_order_entry_t legacy_order[] = {
   { {44.0f }, "lowlight", 0},
   { {45.0f }, "monochrome", 0},
   { {45.3f }, "sigmoid", 0},
+  { {45.5f }, "agx", 0},
   { {46.0f }, "filmic", 0},
   { {46.5f }, "filmicrgb", 0},
   { {47.0f }, "colisa", 0},
@@ -253,6 +254,7 @@ const dt_iop_order_entry_t v30_order[] = {
                                   //    on camera JPEG default look
   { {45.0f }, "filmic", 0},          // same, but different (parametric) approach
   { {45.3f }, "sigmoid", 0},
+  { {45.5f }, "agx", 0},
   { {46.0f }, "filmicrgb", 0},       // same, upgraded
   { {36.0f }, "lut3d", 0},           // apply a creative style or film emulation, possibly non-linear
   { {47.0f }, "colisa", 0},          // edit contrast while damaging colour
@@ -370,6 +372,7 @@ const dt_iop_order_entry_t v50_order[] = {
                                   //    on camera JPEG default look
   { {45.0f }, "filmic", 0},          // same, but different (parametric) approach
   { {45.3f }, "sigmoid", 0},
+  { {45.5f }, "agx", 0},
   { {46.0f }, "filmicrgb", 0},       // same, upgraded
   { {36.0f }, "lut3d", 0},           // apply a creative style or film emulation, possibly non-linear
   { {47.0f }, "colisa", 0},          // edit contrast while damaging colour
@@ -487,6 +490,7 @@ const dt_iop_order_entry_t v30_jpg_order[] = {
   { { 44.0f }, "basecurve", 0 },     // conversion from scene-referred to display referred, reverse-engineered
                                      //    on camera JPEG default look
   { { 45.0f }, "filmic", 0 },        // same, but different (parametric) approach
+  { {45.5f }, "agx", 0},
   { { 45.3f }, "sigmoid", 0},
   { { 46.0f }, "filmicrgb", 0 },     // same, upgraded
   { { 36.0f }, "lut3d", 0 },         // apply a creative style or film emulation, possibly non-linear
@@ -608,6 +612,7 @@ const dt_iop_order_entry_t v50_jpg_order[] = {
                                      //    on camera JPEG default look
   { { 45.0f }, "filmic", 0 },        // same, but different (parametric) approach
   { { 45.3f }, "sigmoid", 0},
+  { {45.5f }, "agx", 0},
   { { 46.0f }, "filmicrgb", 0 },     // same, upgraded
   { { 36.0f }, "lut3d", 0 },         // apply a creative style or film emulation, possibly non-linear
   { { 47.0f }, "colisa", 0 },        // edit contrast while damaging colour
@@ -1177,6 +1182,7 @@ GList *dt_ioppr_get_iop_order_list(const dt_imgid_t imgid,
           _insert_before(iop_order_list, "colorbalance", "diffuse");
           _insert_before(iop_order_list, "nlmeans", "blurs");
           _insert_before(iop_order_list, "filmicrgb", "sigmoid");
+          _insert_before(iop_order_list, "filmicrgb", "agx");
           _insert_before(iop_order_list, "colorbalancergb", "colorequal");
           _insert_before(iop_order_list, "highlights", "rasterfile");
         }

src/common/utility.c

@@ -1162,7 +1162,8 @@ gboolean dt_str_commasubstring(const char *list,
 gboolean dt_is_scene_referred(void)
 {
   return dt_conf_is_equal("plugins/darkroom/workflow", "scene-referred (filmic)")
-    || dt_conf_is_equal("plugins/darkroom/workflow", "scene-referred (sigmoid)");
+    || dt_conf_is_equal("plugins/darkroom/workflow", "scene-referred (sigmoid)")
+    || dt_conf_is_equal("plugins/darkroom/workflow", "scene-referred (agx)");
 }
 
 gboolean dt_is_display_referred(void)

src/iop/CMakeLists.txt

@@ -152,6 +152,7 @@ add_iop(cacorrectrgb "cacorrectrgb.c")
 add_iop(diffuse "diffuse.c")
 add_iop(blurs "blurs.c")
 add_iop(sigmoid "sigmoid.c")
+add_iop(agx "agx.c")
 add_iop(primaries "primaries.c")
 add_iop(colorequal "colorequal.c")
 add_iop(rasterfile "rasterfile.c")