Skip to content

Commit 77ff8d9

Browse files
authored
Bump k8s min k8s version to 1.19 (#2157)
* Bump min k8s version to 1.19 This patch bumps min k8s version to 1.19 Pelase also see https://github.com/knative/community/blob/main/mechanics/RELEASE-VERSIONING-PRINCIPLES.md#knative-serving-version-table * Fix link * Update link to mkdoc's
1 parent 192b0c9 commit 77ff8d9

File tree

2 files changed

+9
-10
lines changed

2 files changed

+9
-10
lines changed

version/version.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,8 @@ const (
3232

3333
// NOTE: If you are changing this line, please also update the minimum kubernetes
3434
// version listed here:
35-
// https://github.com/knative/docs/blob/main/docs/install/any-kubernetes-cluster.md#before-you-begin
36-
// https://github.com/knative/docs/blob/main/docs/install/knative-with-operators.md#prerequisites
37-
defaultMinimumVersion = "v1.18.0"
35+
// https://github.com/knative/docs/blob/mkdocs/docs/snippets/prerequisites.md
36+
defaultMinimumVersion = "v1.19.0"
3837
)
3938

4039
func getMinimumVersion() string {

version/version_test.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,13 @@ func TestVersionCheck(t *testing.T) {
4141
wantError bool
4242
}{{
4343
name: "greater version (patch)",
44-
actualVersion: &testVersioner{version: "v1.18.2"},
44+
actualVersion: &testVersioner{version: "v1.19.2"},
4545
}, {
4646
name: "greater version (patch), no v",
47-
actualVersion: &testVersioner{version: "1.18.2"},
47+
actualVersion: &testVersioner{version: "1.19.2"},
4848
}, {
4949
name: "greater version (patch), pre-release",
50-
actualVersion: &testVersioner{version: "1.18.2-kpn-065dce"},
50+
actualVersion: &testVersioner{version: "1.19.2-kpn-065dce"},
5151
}, {
5252
name: "greater version (patch), pre-release, envvar override",
5353
actualVersion: &testVersioner{version: "1.15.11-kpn-065dce"},
@@ -58,16 +58,16 @@ func TestVersionCheck(t *testing.T) {
5858
versionOverride: "1.15.11-0",
5959
}, {
6060
name: "greater version (minor)",
61-
actualVersion: &testVersioner{version: "v1.18.0"},
61+
actualVersion: &testVersioner{version: "v1.19.0"},
6262
}, {
6363
name: "same version",
64-
actualVersion: &testVersioner{version: "v1.18.0"},
64+
actualVersion: &testVersioner{version: "v1.19.0"},
6565
}, {
6666
name: "same version with build",
67-
actualVersion: &testVersioner{version: "v1.18.0+k3s.1"},
67+
actualVersion: &testVersioner{version: "v1.19.0+k3s.1"},
6868
}, {
6969
name: "same version with pre-release",
70-
actualVersion: &testVersioner{version: "v1.18.0-k3s.1"},
70+
actualVersion: &testVersioner{version: "v1.19.0-k3s.1"},
7171
}, {
7272
name: "smaller version",
7373
actualVersion: &testVersioner{version: "v1.14.3"},

0 commit comments

Comments
 (0)