Skip to content

Commit b29198d

Browse files
committed
[gzhttp] Remove returns http-status bad request
1 parent 7fa5377 commit b29198d

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

gzhttp/compress.go

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -465,12 +465,9 @@ func NewWrapper(opts ...option) (func(http.Handler) http.HandlerFunc, error) {
465465
return func(w http.ResponseWriter, r *http.Request) {
466466
w.Header().Add(vary, acceptEncoding)
467467
if contentGzip(r) {
468-
readerGzipBody, err := gzip.NewReader(r.Body)
469-
if err != nil {
470-
http.Error(w, err.Error(), http.StatusBadRequest)
471-
return
468+
if readerGzipBody, err := gzip.NewReader(r.Body); err == nil {
469+
r.Body = io.NopCloser(readerGzipBody)
472470
}
473-
r.Body = io.NopCloser(readerGzipBody)
474471
}
475472

476473
if acceptsGzip(r) {

gzhttp/compress_test.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -90,16 +90,6 @@ func TestMustNewGzipHandler(t *testing.T) {
9090

9191
assertEqual(t, http.DetectContentType([]byte(testBody)), res3.Header().Get("Content-Type"))
9292

93-
// send not compress request body
94-
95-
req4, _ := http.NewRequest("POST", "/whatever", bytes.NewBuffer(testBody))
96-
req4.Header.Set("Content-Encoding", "gzip")
97-
resp4 := httptest.NewRecorder()
98-
handler.ServeHTTP(resp4, req4)
99-
res4 := resp4.Result()
100-
101-
assertEqual(t, 400, res4.StatusCode)
102-
10393
// send compress request body
10494

10595
var b bytes.Buffer

0 commit comments

Comments
 (0)