Skip to content

Commit 9f6b2f2

Browse files
committed
Proper compile configs for macOS (no native_*)
With this we stop using `native_*` compile configs on macOS. - macos_x86-64_static - macos_x86-64_mixed - macos_arm64_static - macos_arm64_mixed It is important to note that it is urgent to fix the following two tickets because tests in libkiwix and zim-tools both uses the deprecated API. With libkiwix now being libkiwix and not kiwixlib, building older versions is more difficult. - kiwix/libkiwix#1225 - openzim/zim-tools#475 Fixes #841
1 parent 6c56a76 commit 9f6b2f2

File tree

5 files changed

+20
-15
lines changed

5 files changed

+20
-15
lines changed

.github/scripts/build_definition.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -27,15 +27,13 @@
2727
| windows | native_mixed | BPd | d | | | BPd | win-x86_64 | win-x86_64-mixed |
2828
----------------------------------------------------------------------------------------------------------------------------------------------
2929
# Osx builds, build binaries on native_dyn and native_static. On anyother things, build only the libraries
30-
| macos | native_dyn | d | d | dB | B | | | macos-x86_64-dyn |
31-
| macos | native_static | | | BP | BP | | macos-x86_64 | |
32-
| macos | native_mixed | BP | BP | | | | macos-x86_64 | |
30+
| macos | macos_x86-64_static| | | BP | BP | | macos-x86_64 | |
31+
| macos | macos_x86-64_mixed | dBP | dBP | d | | | macos-x86_64 | macos-x86_64-dyn |
3332
| macos | ios_arm64 | dB | dB | | | | | ios-arm64-dyn |
3433
| macos | iossimulator_x86_64| dB | dB | | | | | ios-x86_64-dyn |
3534
| macos | iossimulator_arm64 | B | B | | | | | |
3635
| macos | macos_arm64_static | | | BP | BP | | macos-arm64 | |
3736
| macos | macos_arm64_mixed | dBP | dBP | d | | | macos-arm64 | macos-aarch64-dyn |
38-
| macos | macos_x86_64 | B | B | | | | | |
3937
| macos | apple_all_static | | BP | | | | xcframework | |
4038
----------------------------------------------------------------------------------------------------------------------------------------------
4139
| jammy | flatpak | | | | | BP | | |

.github/workflows/cd.yml

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,8 @@ jobs:
225225
fail-fast: false
226226
matrix:
227227
config:
228-
- native_dyn
229-
- native_static
230-
- native_mixed
228+
- macos_x86-64_static
229+
- macos_x86-64_mixed
231230
- macos_arm64_static
232231
- macos_arm64_mixed
233232
- apple_all_static

.github/workflows/ci.yml

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -214,15 +214,13 @@ jobs:
214214
fail-fast: false
215215
matrix:
216216
config:
217-
- native_dyn
218-
- native_static
219-
- native_mixed
217+
- macos_x86-64_static
218+
- macos_x86-64_mixed
220219
- ios_arm64
221220
- iossimulator_x86_64
222221
- iossimulator_arm64
223222
- macos_arm64_static
224223
- macos_arm64_mixed
225-
- macos_x86_64
226224
- apple_all_static
227225
runs-on: macos-14
228226
env:

kiwixbuild/configs/ios.py

Lines changed: 13 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -199,11 +199,21 @@ class macOSArm64Mixed(MixedMixin("macos_arm64_static"), AppleConfigInfo):
199199
min_macos_version = MIN_MACOS_VERSION
200200

201201

202-
class macOSx64(AppleConfigInfo):
203-
name = "macos_x86_64"
202+
class macOSAmd64(AppleConfigInfo):
203+
name = "macos_x86-64_static"
204204
arch = cpu = "x86_64"
205205
host = "x86_64-apple-darwin"
206-
target = "x86_64-apple-macos"
206+
target = "x86_64-apple-darwin"
207+
sdk_name = "macosx"
208+
min_iphoneos_version = None
209+
min_macos_version = MIN_MACOS_VERSION
210+
211+
212+
class macOSAmd64Mixed(MixedMixin("macos_x86-64_static"), AppleConfigInfo):
213+
name = "macos_x86-64_mixed"
214+
arch = cpu = "x86_64"
215+
host = "x86_64-apple-darwin"
216+
target = "x86_64-apple-darwin"
207217
sdk_name = "macosx"
208218
min_iphoneos_version = None
209219
min_macos_version = MIN_MACOS_VERSION

kiwixbuild/dependencies/apple_xcframework.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
class AppleXCFramework(Dependency):
1111
name = "apple_xcframework"
1212
subConfigNames = [
13-
"macos_x86_64",
13+
"macos_x86-64_static",
1414
"macos_arm64_static",
1515
"ios_arm64",
1616
"iossimulator_x86_64",

0 commit comments

Comments
 (0)