Skip to content

Commit 1d7721b

Browse files
authored
fix: avoid direct FBReactNativeSpec usage (#1084)
## 📜 Description Don't use `<FBReactNativeSpec/FBReactNativeSpec.h>` import anymore. ## 💡 Motivation and Context This import was added 3 years ago. I think back to times it was needed (I'm assuming that all specs could be generated in one file or that spec contained some declarations that were needed in other custom specs). However it seems like now it's unnecessary. Moreover in react-native 0.81 it will cause a compilation error (not sure why, maybe react-native doesn't expose this spec publicly anymore). Anyway, this change seems to be compatible with react-native 0.78..0.81, so I think it's safe to merge it as is without additional conditional imports and other stuff. Closes #1081 ## 📢 Changelog ### iOS - removed `<FBReactNativeSpec/FBReactNativeSpec.h>` import; ## 🤔 How Has This Been Tested? Tested via compiling `FabricExample` project. ## 📸 Screenshots (if appropriate): <img width="300" height="650" alt="image" src="https://github.com/user-attachments/assets/71ec7111-43fc-4dc8-9c9a-f74f03f1a7b0" /> ## 📝 Checklist - [x] CI successfully passed - [x] I added new mocks and corresponding unit-tests if library API was changed
1 parent aff3cbe commit 1d7721b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

ios/KeyboardControllerModule.mm

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111

1212
// Thanks to this guard, we won't import this header when we build for the old architecture.
1313
#ifdef RCT_NEW_ARCH_ENABLED
14-
#import <FBReactNativeSpec/FBReactNativeSpec.h>
1514
#import <reactnativekeyboardcontroller/reactnativekeyboardcontroller.h>
1615
#endif
1716

0 commit comments

Comments
 (0)