feat: Cmd-Click to go to folder in new window

Author: kewisch

README.md

@@ -27,7 +27,9 @@ the selected messages.
 A few more tips and tricks:
 * If you want to move to the first folder in the search results, you can press Enter directly. No need to move down to select the folder.
 * You can also assign keyboard shortcuts to copy, go to a folder, or apply tags
-via Thunderbird's [shortcut manager](https://support.mozilla.org/en-US/kb/manage-extension-shortcuts-firefox).
+  via Thunderbird's [shortcut manager](https://support.mozilla.org/en-US/kb/manage-extension-shortcuts-firefox).
+* When going to a folder, ⌘+Enter will open the folder in a new window.
+* Instead of ⌘+Enter you can also use the middle mouse button if you prefer to use the mouse.
 
 <img title="Shortcut Options" width="600" src="src/onboarding/images/shortcuts.png">
 

src/common/util.js

@@ -32,9 +32,12 @@ export async function getValidatedFolders(rootNode, prefName) {
   return folderNodes;
 }
 
-export function cmdOrCtrlKey(event) {
+export function isAltMode(event) {
   const isMac = navigator.platform.toUpperCase().includes("MAC");
-  return isMac ? event.metaKey : event.ctrlKey;
+  const keyAltMode = isMac ? event.metaKey : event.ctrlKey;
+  const mouseAltMode = event instanceof MouseEvent ? event.button == 1 : false;
+
+  return keyAltMode || mouseAltMode;
 }
 
 export async function showNotification(operation, numMessages, destination, dismissTime = 10000) {

src/popup/baseItemList.js

@@ -3,7 +3,7 @@
  * file, You can obtain one at http://mozilla.org/MPL/2.0/.
  * Portions Copyright (C) Philipp Kewisch */
 
-import { cmdOrCtrlKey } from "../common/util.js";
+import { isAltMode } from "../common/util.js";
 
 const DIACRITICS = /[\u0300-\u036f]/g;
 
@@ -381,7 +381,7 @@ export default class BaseItemList extends HTMLElement {
       }
       event.preventDefault();
     } else if (event.key == "Enter" && !event.repeat) {
-      this.dispatchSelect(this.selected, cmdOrCtrlKey(event));
+      this.dispatchSelect(this.selected, isAltMode(event));
     }
   }
 
@@ -391,7 +391,7 @@ export default class BaseItemList extends HTMLElement {
       let customEvent = new CustomEvent("item-deleted", { detail: listItem.itemNode.item });
       this.dispatchEvent(customEvent);
     } else if (!this.getAttribute("readonly")) {
-      this.dispatchSelect(event.target.closest(".item"), cmdOrCtrlKey(event));
+      this.dispatchSelect(event.target.closest(".item"), isAltMode(event));
     }
   }
 
@@ -434,7 +434,7 @@ export default class BaseItemList extends HTMLElement {
       this.selected = this.nthItem(-1);
       event.preventDefault();
     } else if (event.key == "Enter" && !event.repeat) {
-      await this.enterSelect(cmdOrCtrlKey(event));
+      await this.enterSelect(isAltMode(event));
     }
   }
 

src/popup/popup.js

@@ -4,7 +4,7 @@
  * Portions Copyright (C) Philipp Kewisch */
 
 import { RootNode } from "../common/foldernode.js";
-import { DEFAULT_PREFERENCES, getValidatedFolders, cmdOrCtrlKey } from "../common/util.js";
+import { DEFAULT_PREFERENCES, getValidatedFolders, isAltMode } from "../common/util.js";
 
 const ALL_ACTIONS = ["move", "copy", "goto", "tag"];
 
@@ -202,17 +202,27 @@ async function load() {
     let operation = document.querySelector("input[name='action']:checked").value;
 
     if (operation == "move" || operation == "copy") {
-      await browser.runtime.sendMessage({ action: "processSelectedMessages", folder: folder, operation: operation, goToFolder: altMode });
+      await browser.runtime.sendMessage({
+        action: "processSelectedMessages",
+        folder: folder,
+        operation: operation,
+        goToFolder: altMode
+      });
     } else if (operation == "goto") {
       let [tab] = await browser.tabs.query({ currentWindow: true, active: true });
 
       try {
-        await browser.mailTabs.update(tab.id, { displayedFolder: folder.id });
+        if (altMode) {
+          await browser.mailTabs.create({ displayedFolder: folder.id });
+        } else {
+          await browser.mailTabs.update(tab.id, { displayedFolder: folder.id });
+        }
       } catch (e) {
         if (e.message == "Requested folder is not viewable in any of the enabled folder modes") {
           document.getElementById("tags-view-missing-warning").classList.remove("hidden");
           return;
         }
+        console.error(e);
       }
     }
     window.close();
@@ -258,7 +268,7 @@ function keydown(event) {
     window.close();
   } else if (event.key == "ArrowLeft" || event.key == "ArrowRight") {
     let direction = event.key == "ArrowLeft" ? -1 : 1;
-    if (!cmdOrCtrlKey(event)) {
+    if (!isAltMode(event)) {
       let metaActionWarning = document.getElementById("meta-action-warning");
       if (!event.shiftKey && !metaActionWarning.classList.contains("migrated")) {
         metaActionWarning.classList.remove("hidden");