feat(plugin): support plugin rules

Closes #14

Author: sarbbottam

bin.js

@@ -9,8 +9,13 @@ var eslint = require('eslint')
 var isAbsolute = require('path-is-absolute')
 var findNewRules = require('./index')
 
-var currentRules = getRules()
-var newRules = findNewRules(currentRules)
+var configFile = getConfigFile()
+var config = getConfig(configFile)
+
+var currentRules = getCurrentRules(config)
+var pluginRules = getPluginRules(config)
+
+var newRules = findNewRules(currentRules, pluginRules)
 
 if (newRules.length) {
   console.log('New rules to add to the config: ' + newRules.join(', ') + '.') // eslint-disable-line no-console
@@ -45,13 +50,21 @@ function getConfig(file) {
     // point to the particular config
     configFile: file,
   })
-  var config = cliEngine.getConfigForFile(file)
-  return config
+  return cliEngine.getConfigForFile(file)
+}
+
+function getCurrentRules(conf) {
+  var rules = Object.keys(conf.rules)
+  return rules
 }
 
-function getRules() {
-  var configFile = getConfigFile()
-  var config = getConfig(configFile)
-  var rules = Object.keys(config.rules)
+function getPluginRules(conf) {
+  var rules = []
+  var plugins = conf.plugins
+  if (plugins) {
+    plugins.forEach(function normalizePluginRule(plugin) {
+      rules.concat(require('eslint-plugin-' + plugin).rules)
+    })
+  }
   return rules
 }

index.js

@@ -3,13 +3,17 @@ var difference = require('lodash.difference')
 
 module.exports = findNewRules
 
-function findNewRules(currentRules) {
+function findNewRules(currentRules, pluginRules) {
   var allRules = fs
     .readdirSync('./node_modules/eslint/lib/rules')
     .map(function removeJsFromFilename(filename) {
       return filename.replace(/\.js$/, '')
     })
 
+  if (pluginRules) {
+    allRules = allRules.concat(pluginRules)
+  }
+
   return difference(allRules, currentRules)
 }
 

package.json

@@ -36,6 +36,7 @@
     "cz-conventional-changelog": "1.1.5",
     "eslint": "2.4.0",
     "eslint-config-kentcdodds": "6.0.0",
+    "eslint-plugin-react": "^4.2.3",
     "ghooks": "1.0.3",
     "npm-run-all": "1.5.3",
     "nyc": "6.1.1",

test/fixtures/.eslintrc.js

@@ -1,5 +1,8 @@
 module.exports = {
   rules: {
     "no-console": [2],
-  }
+  },
+  "plugins": [
+    "react"
+  ]
 }

test/index.js

@@ -8,8 +8,8 @@ const findNewRules = proxyquire('../index', {
 })
 
 test('returns the difference between what it finds in eslint/lib/rules and the rules array it is passed', t => {
-  const missingRules = findNewRules(['baz-thing', 'foo-rule'])
-  t.same(missingRules, ['bar-rule'])
+  const missingRules = findNewRules(['baz-thing', 'foo-rule'], ['react-foo'])
+  t.same(missingRules, ['bar-rule', 'react-foo'])
 })
 
 test('returns an empty array if there is no difference', t => {