Fix Proton Pass importer not importing email when there is no username

Samuel Rac · droidmonkey · commit 217ee0157273 · 2025-06-22T11:00:25.000-04:00
diff --git a/src/format/ProtonPassReader.cpp b/src/format/ProtonPassReader.cpp
@@ -73,7 +73,13 @@ namespace
             }
 
             if (loginMap.contains("itemEmail")) {
-                entry->attributes()->set("login_email", loginMap.value("itemEmail").toString());
+                // Place the email value as the username if empty, otherwise set it as an attribute
+                const auto email = loginMap.value("itemEmail").toString();
+                if (entry->username().isEmpty()) {
+                    entry->setUsername(email);
+                } else if (!email.isEmpty()) {
+                    entry->attributes()->set("login_email", email);
+                }
             }
 
             // Set the entry url(s)

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,13 @@ namespace`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`if (loginMap.contains("itemEmail")) {`
`76`		`- entry->attributes()->set("login_email", loginMap.value("itemEmail").toString());`
	`76`	`+ // Place the email value as the username if empty, otherwise set it as an attribute`
	`77`	`+ const auto email = loginMap.value("itemEmail").toString();`
	`78`	`+ if (entry->username().isEmpty()) {`
	`79`	`+ entry->setUsername(email);`
	`80`	`+ } else if (!email.isEmpty()) {`
	`81`	`+ entry->attributes()->set("login_email", email);`
	`82`	`+ }`
`77`	`83`	`}`
`78`	`84`
`79`	`85`	`// Set the entry url(s)`