Skip to content

Commit 9f0ed8b

Browse files
CI hotfix: xfail test_training_with_transformers_paged for transformers<4.57.0 (huggingface#4120)
1 parent 27f22ba commit 9f0ed8b

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tests/slow/test_grpo_slow.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -173,8 +173,8 @@ def test_training_with_liger_grpo_loss_and_peft(self, model_name):
173173
@parameterized.expand(MODELS_TO_TEST)
174174
def test_training_with_transformers_paged(self, model_name):
175175
"""Test that training works with transformers paged implementation (requires GPU)."""
176-
if Version(transformers.__version__) < Version("4.56.2"):
177-
pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.56.2")
176+
if Version(transformers.__version__) < Version("4.57.0"):
177+
pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.57.0")
178178
training_args = GRPOConfig(
179179
output_dir=self.tmp_dir,
180180
learning_rate=0.1, # increase the learning rate to speed up the test

tests/test_online_dpo_trainer.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -422,8 +422,8 @@ def test_generation_config_setup(self):
422422
@require_torch_accelerator
423423
@parameterized.expand([("standard_prompt_only",), ("conversational_prompt_only",)])
424424
def test_training_with_transformers_paged(self, config_name):
425-
if Version(transformers.__version__) < Version("4.56.2"):
426-
pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.56.2")
425+
if Version(transformers.__version__) < Version("4.57.0"):
426+
pytest.xfail("Upstream bug in transformers (GH#40692). Fix merged; awaiting release >= 4.57.0")
427427
training_args = OnlineDPOConfig(
428428
output_dir=self.tmp_dir,
429429
per_device_train_batch_size=2,

0 commit comments

Comments
 (0)