Add prefix for resource names not to delete unexpected resources with teardown command

Author: k-yomo

internal/algoliautil/testutil.go

@@ -0,0 +1,3 @@
+package algoliautil
+
+const TestIndexNamePrefix = "tf_provider_test"

internal/provider/data_source_index_test.go

@@ -8,7 +8,7 @@ import (
 )
 
 func TestAccDataSourceIndex(t *testing.T) {
-	indexName := randStringStartWithAlpha(100)
+	indexName := randResourceID(100)
 	dataSourceName := fmt.Sprintf("data.algolia_index.%s", indexName)
 
 	resource.ParallelTest(t, resource.TestCase{

internal/provider/provider.go

@@ -2,6 +2,7 @@ package provider
 
 import (
 	"context"
+
 	"github.com/algolia/algoliasearch-client-go/v3/algolia/region"
 	"github.com/algolia/algoliasearch-client-go/v3/algolia/search"
 	"github.com/algolia/algoliasearch-client-go/v3/algolia/suggestions"

internal/provider/resource_api_key_test.go

@@ -12,7 +12,7 @@ import (
 )
 
 func TestAccResourceAPIKey(t *testing.T) {
-	name := randStringStartWithAlpha(100)
+	name := randResourceID(100)
 	resourceName := fmt.Sprintf("algolia_api_key.%s", name)
 
 	resource.ParallelTest(t, resource.TestCase{

internal/provider/resource_index_test.go

@@ -11,7 +11,7 @@ import (
 
 // TODO: Cover all fields
 func TestAccResourceIndex(t *testing.T) {
-	indexName := randStringStartWithAlpha(100)
+	indexName := randResourceID(100)
 	resourceName := fmt.Sprintf("algolia_index.%s", indexName)
 
 	resource.ParallelTest(t, resource.TestCase{
@@ -90,7 +90,7 @@ func TestAccResourceIndexWithReplica(t *testing.T) {
 	// TODO: Remove t.Skip() once the issue is resolved.
 	t.Skip()
 
-	primaryIndexName := randStringStartWithAlpha(80)
+	primaryIndexName := randResourceID(80)
 	replicaIndexName := fmt.Sprintf("%s_replica", primaryIndexName)
 	primaryIndexResourceName := fmt.Sprintf("algolia_index.%s", primaryIndexName)
 	replicaIndexResourceName := fmt.Sprintf("algolia_index.%s", replicaIndexName)

internal/provider/resource_query_suggestions_test.go

@@ -12,8 +12,8 @@ import (
 )
 
 func TestAccResourceQuerySuggestions(t *testing.T) {
-	indexName := randStringStartWithAlpha(100)
-	sourceIndexName := randStringStartWithAlpha(100)
+	indexName := randResourceID(100)
+	sourceIndexName := randResourceID(100)
 	resourceName := fmt.Sprintf("algolia_query_suggestions.%s", indexName)
 
 	resource.ParallelTest(t, resource.TestCase{

internal/provider/resource_rule_test.go

@@ -11,8 +11,8 @@ import (
 )
 
 func TestAccResourceRule(t *testing.T) {
-	indexName := randStringStartWithAlpha(100)
-	objectID := randStringStartWithAlpha(64)
+	indexName := randResourceID(100)
+	objectID := randResourceID(64)
 	resourceName := fmt.Sprintf("algolia_rule.%s", objectID)
 
 	resource.ParallelTest(t, resource.TestCase{

internal/provider/resource_synonyms_test.go

@@ -10,7 +10,7 @@ import (
 )
 
 func TestAccResourceSynonyms(t *testing.T) {
-	indexName := randStringStartWithAlpha(100)
+	indexName := randResourceID(100)
 	resourceName := fmt.Sprintf("algolia_synonyms.%s", indexName)
 
 	resource.ParallelTest(t, resource.TestCase{

internal/provider/resource_virtual_index_test.go

@@ -13,7 +13,7 @@ func TestAccResourceVirtualIndex(t *testing.T) {
 	// TODO: Remove t.Skip() once the issue is resolved.
 	t.Skip()
 
-	indexName := randStringStartWithAlpha(80)
+	indexName := randResourceID(80)
 	virtualIndexName := fmt.Sprintf("%s_virtual", indexName)
 	indexResourceName := fmt.Sprintf("algolia_index.%s", indexName)
 	virtualIndexResourceName := fmt.Sprintf("algolia_virtual_index.%s", virtualIndexName)

internal/provider/testutils.go

@@ -5,6 +5,7 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/acctest"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+	"github.com/hashicorp/terraform-provider-algolia/internal/algoliautil"
 	"github.com/rs/xid"
 )
 
@@ -17,14 +18,15 @@ func testCheckResourceListAttr(name, key string, values []string) resource.TestC
 	return resource.ComposeTestCheckFunc(testCheckFuncs...)
 }
 
-// The first character must be alphabet for algolia resources
-func randStringStartWithAlpha(length int) string {
-	const uuidLen = 21 // firstChar + xid(20 chars)
-	uuid := acctest.RandStringFromCharSet(1, acctest.CharSetAlpha) + xid.New().String()
+// randResourceID generates unique id string
+// id length must be longer than (prefix + uuid length)
+func randResourceID(length int) string {
+	// The first character must be alphabet for algolia resources
+	uuid := algoliautil.TestIndexNamePrefix + xid.New().String()
 
-	if length < uuidLen {
-		return uuid[:length]
+	if length < len(uuid) {
+		panic(fmt.Sprintf("length must be longer than %d", len(uuid)))
 	}
 
-	return uuid + acctest.RandStringFromCharSet(length-uuidLen, acctest.CharSetAlphaNum)
+	return uuid + acctest.RandStringFromCharSet(length-len(uuid), acctest.CharSetAlphaNum)
 }