fix: fixes for escaping

Author: agoose77

package-lock.json

@@ -140,6 +140,7 @@ export async function transformMystXRefs(
       } else {
         const data = await fetchMystXRefData(session, node as CrossReference, vfile);
         if (!data) return;
+        console.debug({ identifier: node.identifier });
         const targets = nodesFromMystXRefData(data, node.identifier, vfile, {
           urlSource: node.urlSource,
           maxNodes: 1,

packages/myst-cli/src/transforms/crossReferences.ts

@@ -19,6 +19,7 @@
     "build": "npm-run-all -l clean -p build:esm"
   },
   "dependencies": {
+    "css.escape": "^1.5.1",
     "mdast": "^3.0.0",
     "myst-frontmatter": "^1.7.4",
     "myst-spec": "^0.0.5",
@@ -31,9 +32,10 @@
     "vfile-message": "^4.0.0"
   },
   "devDependencies": {
-    "myst-spec-ext": "^1.7.4",
-    "unist-builder": "4.0.0",
     "@jupyterlab/nbformat": "^3.5.2",
-    "@lumino/coreutils": "^2.0.0"
+    "@lumino/coreutils": "^2.0.0",
+    "@types/css.escape": "^1.5.2",
+    "myst-spec-ext": "^1.7.4",
+    "unist-builder": "4.0.0"
   }
 }

packages/myst-common/package.json

@@ -1,6 +1,7 @@
 import { selectAll } from 'unist-util-select';
 import { EXIT, SKIP, visit } from 'unist-util-visit';
 import type { GenericNode, GenericParent } from './types.js';
+import escape from 'css.escape';
 
 /**
  * Determine if node with `identifier` should be considered a target
@@ -85,9 +86,11 @@ export function selectMdastNodes(
 ): { htmlId?: string; nodes: GenericNode[] } {
   if (maxNodes === 0) return { nodes: [] };
   // Select the first identifier that is not a crossReference or citation
-  const node = selectAll(`[identifier=${identifier}],[key=${identifier}]`, mdast).find((n) =>
-    isTargetIdentifierNode(n),
-  ) as GenericNode | undefined;
+  const escapedIdentifier = escape(identifier);
+  const node = selectAll(
+    `[identifier=${escapedIdentifier}],[key=${escapedIdentifier}]`,
+    mdast,
+  ).find((n) => isTargetIdentifierNode(n)) as GenericNode | undefined;
   if (!node) return { nodes: [] };
   switch (node.type) {
     case 'heading':