Skip to content

Commit 3d598bb

Browse files
committed
fix: varsup and indsup renamed to supvar and supind in GDAtools
1 parent 7a7e352 commit 3d598bb

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
# explor (development version)
22

3+
- Fix varsup and indsup functions renamed to supvar and supind in GDAtools
34
- Fix duplicated level names in supplementary variables in speMCA
45
- Fix warnings in Font Awesome icon names (#39, thanks @jl5000)
56
- Fix supplementary variables not displayed in individual plot for speMCA (thanks @419kfj)

R/utils.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
speMCA_varsup <- function(mca, df) {
1616
if (!is.data.frame(df)) stop("df must be a data frame")
1717
res <- lapply(names(df), function(name) {
18-
l <- GDAtools::varsup(mca, df[, name])
18+
l <- GDAtools::supvar(mca, df[, name])
1919
l <- lapply(l, function(x) {
2020
if (is.data.frame(x)) {
2121
rownames(x) <- paste(name, rownames(x), sep = "____")

tests/testthat/test_prepare_results_speMCA.R

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ context("prepare_results.speMCA")
33

44
data(Music)
55
mca <- GDAtools::speMCA(Music[3:nrow(Music), 1:4], excl = c(3, 6, 9, 12))
6-
mca$supi <- indsup(mca, Music[1:2, 1:4])
6+
mca$supi <- GDAtools::supind(mca, Music[1:2, 1:4])
77
mca$supv <- speMCA_varsup(mca, Music[3:nrow(Music), 5:6])
88

99
res <- prepare_results(mca)
@@ -56,11 +56,11 @@ test_that("Supplementary individuals results are equal", {
5656

5757
test_that("Supplementary variables results are equal", {
5858
expect_equal(
59-
round(GDAtools::varsup(mca, Music[3:nrow(Music), 5])$coord[, 1], 3),
59+
round(GDAtools::supvar(mca, Music[3:nrow(Music), 5])$coord[, 1], 3),
6060
data.frame(res$vars)[res$vars$Type == "Supplementary" & res$vars$Variable == "Classical" & res$vars$Axis == "1", "Coord"]
6161
)
6262
expect_equal(
63-
round(GDAtools::varsup(mca, Music[3:nrow(Music), 6])$cos2[, 2], 3),
63+
round(GDAtools::supvar(mca, Music[3:nrow(Music), 6])$cos2[, 2], 3),
6464
data.frame(res$vars)[res$vars$Type == "Supplementary" & res$vars$Variable == "Gender" & res$vars$Axis == "2", "Cos2"]
6565
)
6666
})
@@ -73,4 +73,4 @@ test_that("Qualitative data are equal", {
7373
as.character(tmp[ids, "FrenchPop"]),
7474
as.character(Music[ids, "FrenchPop"])
7575
)
76-
})
76+
})

0 commit comments

Comments
 (0)