Skip to content

Commit 82f6c33

Browse files
authored
fix(modelgateway): kafka topics with correct number of partitions (SeldonIO#5427)
The number of partitions with which model-specific kafka topics is created needs to be the same as the number of partitions for other topics (pipelines/experiments/etc). This is a Kafka Streams constraint in order for joins to work correctly. Until now, an incorrect environment variable was being passed to modelgateway, which meant that it was always creating topics with 1 partition. This in turn led to dataflow processing getting stuck whenever other topics were created with multiple partitions **Fixed issues**: - INFRA-822: Pipelines get stuck on triggers/joins
1 parent 6560267 commit 82f6c33

File tree

4 files changed

+4
-4
lines changed

4 files changed

+4
-4
lines changed

k8s/helm-charts/seldon-core-v2-setup/templates/seldon-v2-components.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1163,7 +1163,7 @@ spec:
11631163
value: '{{ .Values.modelgateway.workers }}'
11641164
- name: KAFKA_DEFAULT_REPLICATION_FACTOR
11651165
value: '{{ .Values.kafka.topics.replicationFactor }}'
1166-
- name: KAFKA_DEFAULT_PARTITIONS_DEFAULT
1166+
- name: KAFKA_DEFAULT_NUM_PARTITIONS
11671167
value: '{{ .Values.kafka.topics.numPartitions }}'
11681168
- name: CONTROL_PLANE_SECURITY_PROTOCOL
11691169
value: '{{ .Values.security.controlplane.protocol }}'

k8s/helm-charts/seldon-core-v2-setup/values.yaml.template

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -252,7 +252,7 @@ serverConfig:
252252
pullPolicy: IfNotPresent
253253
registry: docker.io
254254
repository: seldonio/mlserver
255-
tag: 1.3.5
255+
tag: 1.5.0
256256
serverCapabilities: "mlserver,alibi-detect,alibi-explain,huggingface,lightgbm,mlflow,python,sklearn,spark-mlib,xgboost"
257257
modelVolumeStorage: 1Gi
258258
resources:

k8s/kustomize/helm-components-sc/patch_modelgateway.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ spec:
1414
value: '{{ .Values.modelgateway.workers }}'
1515
- name: KAFKA_DEFAULT_REPLICATION_FACTOR
1616
value: '{{ .Values.kafka.topics.replicationFactor }}'
17-
- name: KAFKA_DEFAULT_PARTITIONS_DEFAULT
17+
- name: KAFKA_DEFAULT_NUM_PARTITIONS
1818
value: '{{ .Values.kafka.topics.numPartitions }}'
1919
- name: CONTROL_PLANE_SECURITY_PROTOCOL
2020
value: '{{ .Values.security.controlplane.protocol }}'

k8s/yaml/components.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -796,7 +796,7 @@ spec:
796796
value: '8'
797797
- name: KAFKA_DEFAULT_REPLICATION_FACTOR
798798
value: '1'
799-
- name: KAFKA_DEFAULT_PARTITIONS_DEFAULT
799+
- name: KAFKA_DEFAULT_NUM_PARTITIONS
800800
value: '1'
801801
- name: CONTROL_PLANE_SECURITY_PROTOCOL
802802
value: 'PLAINTEXT'

0 commit comments

Comments
 (0)