[Fix] jsx-props-no-multi-spaces: avoid a crash on long member chains in tag names in typescript-eslint parser

Author: ljharb

CHANGELOG.md

@@ -12,6 +12,7 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel
 ### Fixed
 * [`propTypes`]: add `VoidFunctionComponent` to react generic list ([#3092][] @vedadeepta)
 * [`jsx-fragments`], [`jsx-no-useless-fragment`]: avoid a crash on fragment syntax in `typescript-eslint` parser (@ljharb)
+* [`jsx-props-no-multi-spaces`]: avoid a crash on long member chains in tag names in `typescript-eslint` parser (@ljharb)
 
 [#3092]: https://github.com/yannickcr/eslint-plugin-react/pull/3092
 [#2166]: https://github.com/yannickcr/eslint-plugin-react/pull/2166

lib/rules/jsx-props-no-multi-spaces.js

@@ -44,7 +44,9 @@ module.exports = {
         case 'JSXMemberExpression':
           return `${getPropName(propNode.object)}.${propNode.property.name}`;
         default:
-          return propNode.name.name;
+          return propNode.name
+            ? propNode.name.name
+            : `${context.getSourceCode().getText(propNode.object)}.${propNode.property.name}`; // needed for typescript-eslint parser
       }
     }
 

tests/lib/rules/jsx-props-no-multi-spaces.js

@@ -242,15 +242,18 @@ ruleTester.run('jsx-props-no-multi-spaces', rule, {
       ],
     },
     {
-      code: '<Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh  xyzzy="thud" />',
-      output: '<Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh xyzzy="thud" />',
+      code: `
+        <Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh  xyzzy="thud" />
+      `,
+      output: `
+        <Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh xyzzy="thud" />
+      `,
       errors: [
         {
           messageId: 'onlyOneSpace',
           data: { prop1: 'Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh', prop2: 'xyzzy' },
         },
       ],
-      features: ['no-ts-old'], // TODO: FIXME: remove `no-ts-old` and fix
     },
     {
       code: `