Close ZK before canceling future with exception (apache#6228) (apache#6399)

pawellozinski · jiazhai · commit e2f2071f48bc · 2020-05-18T07:48:21.000+08:00
Fixes apache#6228 (cherry picked from commit e6a631d)
diff --git a/pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZookeeperBkClientFactoryImpl.java b/pulsar-zookeeper-utils/src/main/java/org/apache/pulsar/zookeeper/ZookeeperBkClientFactoryImpl.java
@@ -55,6 +55,7 @@ public CompletableFuture<ZooKeeper> create(String serverList, SessionType sessio
                         .build();
 
                 if (zk.getState() == States.CONNECTEDREADONLY && sessionType != SessionType.AllowReadOnly) {
+                    zk.close();
                     future.completeExceptionally(new IllegalStateException("Cannot use a read-only session"));
                 }
 

Original file line number	Diff line number	Diff line change
`@@ -55,6 +55,7 @@ public CompletableFuture<ZooKeeper> create(String serverList, SessionType sessio`
`55`	`55`	`.build();`
`56`	`56`
`57`	`57`	`if (zk.getState() == States.CONNECTEDREADONLY && sessionType != SessionType.AllowReadOnly) {`
	`58`	`+ zk.close();`
`58`	`59`	`future.completeExceptionally(new IllegalStateException("Cannot use a read-only session"));`
`59`	`60`	`}`
`60`	`61`