Skip to content

Commit d1474b3

Browse files
authored
Merge pull request #171 from rensbaardman/stack-trace-test-firefox
2 parents b70fdc0 + 9f194a7 commit d1474b3

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

testLib/sharedTestCases.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,18 @@ module.exports = function () {
284284
try {
285285
throwError();
286286
} catch (err) {
287-
expect(err.stack.split("\n")[1]).to.match(/:6:26/);
287+
288+
// Firefox implements a different error-stack format,
289+
// but does offer line and column numbers on errors: we use
290+
// those instead.
291+
if (err.lineNumber !== undefined && err.columnNumber !== undefined) {
292+
expect(err.lineNumber).to.equal(6)
293+
expect(err.columnNumber).to.equal(26)
294+
}
295+
// This is for the V8 stack trace format (Node, Chrome)
296+
else {
297+
expect(err.stack.split("\n")[1]).to.match(/:6:26/);
298+
}
288299
}
289300
});
290301

0 commit comments

Comments
 (0)