Skip to content

feat(rules): add no-test-prefixes rule #70

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 12, 2018
Merged

feat(rules): add no-test-prefixes rule #70

merged 2 commits into from
Feb 12, 2018

Conversation

@ranyitz
Copy link
Contributor

@ranyitz ranyitz commented Feb 11, 2018 •
edited
Loading

This PR adds the no-test-prefixes rule that discussed in #63

TL;DR
Do not use f and x prefixes for focused/skipped tests.

@SimenB
Copy link
Member

SimenB commented Feb 12, 2018

This is great! I'm not sure about the name, though... @thymikee ideas for a better name?

@thymikee
Copy link
Member

thymikee commented Feb 12, 2018

Dang, this is hard to tackle. prefer-no-aliased-test-methods is maybe more generic?

@SimenB
Copy link
Member

SimenB commented Feb 12, 2018

prefer-no-modifier-prefix?

@thymikee
Copy link
Member

thymikee commented Feb 12, 2018

prefer-no-test-prefixes?

@ranyitz
Copy link
Contributor Author

ranyitz commented Feb 12, 2018

no-test-prefixes?

@SimenB
Copy link
Member

SimenB commented Feb 12, 2018

no-test-prefixes 👍

@ranyitz
Copy link
Contributor Author

ranyitz commented Feb 12, 2018

@SimenB @thymikee Ok great, I will change it later on today 😊

@ranyitz
Copy link
Contributor Author

ranyitz commented Feb 12, 2018

I've updated the name and the PR is ready for a review/merge 🙂

SimenB
SimenB approved these changes Feb 12, 2018
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thymikee thymikee changed the title feat(rules): add prefer-only-skip rule feat(rules): add no-test-prefixes rule Feb 12, 2018
@SimenB SimenB merged commit a12a2d2 into jest-community:master Feb 12, 2018
@ranyitz ranyitz deleted the prefer-only-skip branch February 12, 2018 21:40
This was referenced Feb 12, 2018
Merged
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Mar 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SimenB SimenB SimenB approved these changes

@thymikee thymikee thymikee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ranyitz @SimenB @thymikee