Fix: Correctly merge overlapping points in LFO editor

Previously, duplicate points created by tools like the square brush were not being merged. This resulted in a poor user experience, as multiple points could exist at the same visual location. Dragging such a point would only move one, leaving the others behind and breaking the perceived shape.

This commit resolves the issue by replacing the direct comparison with a robust, epsilon-based distance check.

Key changes:
- Implemented `mergeDuplicatePoints()` to use `getDistanceFrom()` with a small epsilon to correctly identify points that are effectively duplicates.
- The function now manually rebuilds the points list, ensuring that the `curvatures` array is kept in sync with the points array, preventing data corruption and potential crashes.
- The merge function is now called after mouse-up events (e.g., finishing a brush stroke or drag), ensuring the LFO data is always clean.

Author: jerryuhoo

Source/DSP/LfoData.h

@@ -42,6 +42,51 @@ struct LfoData
         smoothness = 0.0f; // Reset smoothness to default.
     }
 
+    /**
+     * @brief Removes duplicate or very close points to clean up the LFO shape.
+     * It uses an epsilon for robust floating-point comparison and also ensures
+     * the 'curvatures' array remains synchronized with the 'points' array.
+    */
+    void mergeDuplicatePoints()
+    {
+        // Do nothing if there are not enough points to have duplicates.
+        if (points.size() < 2)
+            return;
+
+        // A small tolerance to consider two float values as equal.
+        constexpr float epsilon = 0.0001f;
+
+        // Create new vectors to store the unique points and their corresponding curvatures.
+        std::vector<juce::Point<float>> uniquePoints;
+        std::vector<float> updatedCurvatures;
+
+        // Always add the first point.
+        uniquePoints.push_back(points.front());
+
+        // Iterate through the rest of the points, starting from the second one.
+        for (int i = 1; i < points.size(); ++i)
+        {
+            // Compare the distance from the current point to the last unique point found.
+            if (points[i].getDistanceFrom(uniquePoints.back()) > epsilon)
+            {
+                // If the point is not a duplicate, add it to the unique list.
+                uniquePoints.push_back(points[i]);
+
+                // IMPORTANT: Also add the curvature of the segment *preceding* this new point.
+                // The number of curvatures is always one less than the number of points.
+                // So, the curvature at index i-1 corresponds to the segment between point i-1 and i.
+                if (i - 1 < curvatures.size())
+                {
+                    updatedCurvatures.push_back(curvatures[i - 1]);
+                }
+            }
+        }
+
+        // After checking all points, replace the old data with the cleaned-up versions.
+        points = uniquePoints;
+        curvatures = updatedCurvatures;
+    }
+
     // Writes the current LfoData to an XmlElement.
     void writeToXml(juce::XmlElement& xml) const
     {

Source/Panels/ControlPanel/LfoPanel.cpp

@@ -517,6 +517,8 @@ void LfoEditor::mouseUp(const juce::MouseEvent& event)
 
     if (dataWasChanged && onDataChanged)
     {
+        if (activeLfoData)
+            activeLfoData->mergeDuplicatePoints();
         onDataChanged();
     }
 }

tests/Presets/lfo_smooth.fire

@@ -33,12 +33,10 @@
     <LFO index="0" smoothness="0.5399999618530273">
       <POINTS>
         <P x="0.0" y="1.0"/>
-        <P x="0.2499900013208389" y="1.0"/>
-        <P x="0.2500100135803223" y="1.0"/>
+        <P x="0.25" y="1.0"/>
         <P x="0.4999899864196777" y="1.0"/>
         <P x="0.5000100135803223" y="0.0"/>
-        <P x="0.7499899864196777" y="0.0"/>
-        <P x="0.7500100135803223" y="0.0"/>
+        <P x="0.75" y="0.0"/>
         <P x="1.0" y="0.0"/>
       </POINTS>
       <CURVATURES>
@@ -47,8 +45,6 @@
         <C v="0.0"/>
         <C v="0.0"/>
         <C v="0.0"/>
-        <C v="0.0"/>
-        <C v="0.0"/>
       </CURVATURES>
     </LFO>
     <LFO index="1" smoothness="0.0">