Finding all violations for files

* Even if same file is reported twice (with absolute and relative path)

Author: tomasbjerre

src/main/java/org/jenkinsci/plugins/jvcts/perform/JvctsPerformer.java

@@ -95,17 +95,18 @@ private static void commentStash(Map<String, List<Violation>> violationsPerFile,
   */
  private static List<Violation> getViolationsForFile(Map<String, List<Violation>> violationsPerFile,
    String changedFileInStash, BuildListener listener) {
+  List<Violation> found = newArrayList();
   for (String reportedFile : violationsPerFile.keySet()) {
    if (reportedFile.endsWith(changedFileInStash) || changedFileInStash.endsWith(reportedFile)) {
     JvctsLogger.doLog(listener, FINE, "Changed file and reported file matches. Stash: \"" + changedFileInStash
       + "\" Reported: \"" + reportedFile + "\"");
-    return violationsPerFile.get(reportedFile);
+    found.addAll(violationsPerFile.get(reportedFile));
    } else {
     doLog(listener, FINE, "Changed file and reported file not matching. Stash: \"" + changedFileInStash
       + "\" Reported: \"" + reportedFile + "\"");
    }
   }
-  return newArrayList();
+  return found;
  }
 
  private static String constructCommentMessage(Violation v) {

src/test/java/org/jenkinsci/plugins/jvcts/stash/StashClientFaker.java

@@ -61,6 +61,7 @@ public String invokeUrl(ViolationsToStashConfig config, String url, Method metho
   fake(readFile("checkstyle_checkstylefile_1.json"), "");
   fake(readFile("checkstyle_checkstylefile_2.json"), "");
   fake(readFile("checkstyle_checkstylefile_3_relativePath.json"), "");
+  fake(readFile("checkstyle_checkstylefile_3.json"), "");
   fake(readFile("checkstyle_pmdandcheckstyle.json"), "");
   fake(readFile("pmd_pmdandcheckstyle.json"), "");
   fake(readFile("pmd_pmdfile.json"), "");

src/test/resources/checkstyle_checkstylefile_3.json

@@ -0,0 +1 @@
+http://stash.server/rest/api/1.0/projects/stashProject/repos/stashRepo/pull-requests/1/comments POST { "text": "checkstyle L77 Low (4) Same file also rel.", "anchor": { "line": "77", "lineType": "ADDED", "fileType": "TO", "path": "module/src/main/java/se/bjurr/code/CheckstyleFile.java" }}

src/test/resources/freestyle/checkstyle/checkstyle_relativePath.xml

@@ -3,4 +3,7 @@
 <file name="../module/src/main/java/se/bjurr/code/CheckstyleFileRel.java">
  <error line="10" column="25" severity="warning" message="Relative path." source="com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck"/>
 </file>
+<file name="../module/src/main/java/se/bjurr/code/CheckstyleFile.java">
+ <error line="77" severity="info" message="Same file also rel." source="com.puppycrawl.tools.checkstyle.checks.TrailingCommentCheck"/>
+</file>
 </checkstyle>