Skip to content

Commit b6bdb28

Browse files
Update dependency org.jenkins-ci:jenkins to v1.131 (#784)
* Update dependency org.jenkins-ci:jenkins to v1.131 * Remove unnecessary spotbugs suppressions --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Mark Waite <[email protected]>
1 parent 553b2e2 commit b6bdb28

File tree

4 files changed

+2
-13
lines changed

4 files changed

+2
-13
lines changed

plugin-management-cli/src/main/java/io/jenkins/tools/pluginmanager/cli/CliOptions.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -485,7 +485,6 @@ private boolean isNoDownload() {
485485
/**
486486
* Prints out the Plugin Management Tool version
487487
*/
488-
@SuppressFBWarnings("RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE")
489488
public void showVersion() {
490489
try (InputStream propertyInputStream = getPropertiesInputStream("/.properties")) {
491490
if (propertyInputStream == null) {

plugin-management-cli/src/main/java/io/jenkins/tools/pluginmanager/cli/Main.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
package io.jenkins.tools.pluginmanager.cli;
22

3-
import edu.umd.cs.findbugs.annotations.SuppressFBWarnings;
43
import io.jenkins.tools.pluginmanager.config.Config;
54
import io.jenkins.tools.pluginmanager.impl.Plugin;
65
import io.jenkins.tools.pluginmanager.impl.PluginManager;
@@ -12,15 +11,6 @@
1211
import org.kohsuke.args4j.ParserProperties;
1312

1413
public class Main {
15-
@SuppressFBWarnings("DM_EXIT")
16-
/*
17-
The @SuppressFBWarnings("DM_EXIT") annotation is added here to suppress FindBugs warnings concerning the direct use of System.exit().The value
18-
"DM_EXIT" corresponds to the specific FindBugs detector for direct exit methods, indicating that this suppression is targeted at that particular
19-
category of warnings. The justification for this suppression is that the usage of System.exit() in this code is intentional and serves a specific
20-
purpose. Placing the justification and value directly in the annotation adheres to the common approach with SuppressFBWarnings, providing explicit
21-
documentation about the deliberate decision to use System.exit() in the code.
22-
*/
23-
2414
public static void main(String[] args) throws IOException {
2515
CliOptions options = new CliOptions();
2616
ParserProperties parserProperties = ParserProperties.defaults().withUsageWidth(150);

plugin-management-library/src/main/java/io/jenkins/tools/pluginmanager/impl/PluginManager.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1290,7 +1290,7 @@ public boolean downloadToFile(String urlString, Plugin plugin, @CheckForNull Fil
12901290
* @param maxRetries Maximum number of times to retry the download before failing
12911291
* @return true if download is successful, false otherwise
12921292
*/
1293-
@SuppressFBWarnings({"PATH_TRAVERSAL_IN", "HTTP_PARAMETER_POLLUTION"})
1293+
@SuppressFBWarnings("PATH_TRAVERSAL_IN")
12941294
public boolean downloadToFile(String urlString, Plugin plugin, @CheckForNull File fileLocation, int maxRetries) {
12951295
File pluginFile;
12961296
if (fileLocation == null) {

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
<parent>
66
<groupId>org.jenkins-ci</groupId>
77
<artifactId>jenkins</artifactId>
8-
<version>1.128</version>
8+
<version>1.131</version>
99
<relativePath />
1010
</parent>
1111

0 commit comments

Comments
 (0)