Bump org.codehaus.mojo:versions-maven-plugin from 2.17.1 to 2.18.0 (#134)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Author: dependabot[bot]

maven-plugin/pom.xml

@@ -26,7 +26,7 @@
         <dependency>
             <groupId>org.codehaus.mojo</groupId>
             <artifactId>versions-maven-plugin</artifactId>
-            <version>2.17.1</version>
+            <version>2.18.0</version>
         </dependency>
         <dependency>
             <groupId>org.apache.maven.plugin-tools</groupId>

maven-plugin/src/main/java/io/jenkins/tools/incrementals/maven/DetectIndent.java

@@ -1,6 +1,6 @@
 package io.jenkins.tools.incrementals.maven;
 
-import org.apache.commons.lang.StringUtils;
+import org.apache.commons.lang3.StringUtils;
 
 public class DetectIndent {
 

maven-plugin/src/main/java/io/jenkins/tools/incrementals/maven/IncrementalifyMojo.java

@@ -58,7 +58,7 @@
 import org.codehaus.mojo.versions.api.VersionRetrievalException;
 import org.codehaus.mojo.versions.api.VersionsHelper;
 import org.codehaus.mojo.versions.api.recording.ChangeRecorder;
-import org.codehaus.mojo.versions.rewriting.ModifiedPomXMLEventReader;
+import org.codehaus.mojo.versions.rewriting.MutableXMLStreamReader;
 import org.eclipse.aether.RepositorySystem;
 import static org.twdata.maven.mojoexecutor.MojoExecutor.*;
 
@@ -120,7 +120,7 @@ public class IncrementalifyMojo extends AbstractVersionsUpdaterMojo {
         }
     }
 
-    @Override protected void update(ModifiedPomXMLEventReader pom) throws MojoExecutionException, MojoFailureException, XMLStreamException {
+    @Override protected void update(MutableXMLStreamReader pom) throws MojoExecutionException, MojoFailureException, XMLStreamException {
         String version = PomHelper.getProjectVersion(pom);
         Matcher m = Pattern.compile("(.+)-SNAPSHOT").matcher(version);
         if (!m.matches()) {
@@ -175,7 +175,7 @@ public class IncrementalifyMojo extends AbstractVersionsUpdaterMojo {
      * @return The parent artifact or <code>null</code> if no parent is specified.
      * @throws XMLStreamException if something went wrong.
      */
-    private static Artifact getProjectParent( final ModifiedPomXMLEventReader pom, VersionsHelper helper )
+    private static Artifact getProjectParent( final MutableXMLStreamReader pom, VersionsHelper helper )
             throws XMLStreamException
     {
         Stack<String> stack = new Stack<>();
@@ -189,11 +189,11 @@ private static Artifact getProjectParent( final ModifiedPomXMLEventReader pom, V
 
         while ( pom.hasNext() )
         {
-            XMLEvent event = pom.nextEvent();
-            if ( event.isStartElement() )
+            pom.next();
+            if ( pom.isStartElement() )
             {
                 stack.push( path );
-                final String elementName = event.asStartElement().getName().getLocalPart();
+                final String elementName = pom.getLocalName();
                 path = path + "/" + elementName;
 
                 if ( matchScopeRegex.matcher( path ).matches() )
@@ -215,7 +215,7 @@ else if ( "version".equals( elementName ) )
                     }
                 }
             }
-            if ( event.isEndElement() )
+            if ( pom.isEndElement() )
             {
                 path = stack.pop();
             }
@@ -245,18 +245,18 @@ static ReplaceGitHubRepo replaceGitHubRepo(String text) throws MojoFailureExcept
         return new ReplaceGitHubRepo(m.group(1) + "${gitHubRepo}" + m.group(3), m.group(2));
     }
 
-    private void prependProperty(ModifiedPomXMLEventReader pom, String name, String value) throws XMLStreamException, MojoFailureException {
+    private void prependProperty(MutableXMLStreamReader pom, String name, String value) throws XMLStreamException, MojoFailureException {
         Stack<String> stack = new Stack<>();
         pom.rewind();
         boolean found = false;
         while (pom.hasNext()) {
-            XMLEvent event = pom.nextEvent();
-            if (event.isStartElement()) {
-                stack.push(event.asStartElement().getName().getLocalPart());
+            pom.next();
+            if (pom.isStartElement()) {
+                stack.push(pom.getLocalName());
                 if (stack.equals(Arrays.asList("project", "properties"))) {
                     pom.mark(0);
                 }
-            } else if (event.isEndElement()) {
+            } else if (pom.isEndElement()) {
                 if (stack.equals(Arrays.asList("project", "properties"))) {
                     pom.mark(1);
                     found = true;

maven-plugin/src/main/java/io/jenkins/tools/incrementals/maven/UpdateMojo.java

@@ -50,7 +50,7 @@
 import org.codehaus.mojo.versions.api.PropertyVersions;
 import org.codehaus.mojo.versions.api.VersionsHelper;
 import org.codehaus.mojo.versions.api.recording.ChangeRecorder;
-import org.codehaus.mojo.versions.rewriting.ModifiedPomXMLEventReader;
+import org.codehaus.mojo.versions.rewriting.MutableXMLStreamReader;
 import org.eclipse.aether.RepositorySystem;
 
 /**
@@ -83,7 +83,7 @@ public class UpdateMojo extends AbstractVersionsDependencyUpdaterMojo {
         super(artifactHandlerManager, repositorySystem, wagonMap, changeRecorders);
     }
 
-    @Override protected void update(ModifiedPomXMLEventReader pom) throws MojoExecutionException, MojoFailureException, XMLStreamException {
+    @Override protected void update(MutableXMLStreamReader pom) throws MojoExecutionException, MojoFailureException, XMLStreamException {
         try {
             UpdateChecker checker = new UpdateChecker(message -> getLog().info(message),
                 // TODO use repos.stream().map(MavenArtifactRepository::getUrl).collect(Collectors.toList()) if UpdateChecker.loadVersions is fixed to exclude snapshots and pass authentication
@@ -108,7 +108,7 @@ public class UpdateMojo extends AbstractVersionsDependencyUpdaterMojo {
         }
     }
 
-    private void update(ModifiedPomXMLEventReader pom, List<Dependency> dependencies, UpdateChecker checker) throws Exception {
+    private void update(MutableXMLStreamReader pom, List<Dependency> dependencies, UpdateChecker checker) throws Exception {
         for (Dependency dep : dependencies) {
             Artifact art = toArtifact(dep);
             if (!isIncluded(art)) {
@@ -136,12 +136,12 @@ private void update(ModifiedPomXMLEventReader pom, List<Dependency> dependencies
                 getLog().info("No update found for " + toString(dep));
             } else {
                 getLog().info("Can update dependency " + toString(dep) + " to " + result.version);
-                PomHelper.setDependencyVersion(pom, groupId, artifactId, version, result.version.toString(), getProject().getModel());
+                PomHelper.setDependencyVersion(pom, groupId, artifactId, version, result.version.toString(), getProject().getModel(), getLog());
             }
         }
     }
 
-    private void updateProperties(ModifiedPomXMLEventReader pom, UpdateChecker checker) throws Exception {
+    private void updateProperties(MutableXMLStreamReader pom, UpdateChecker checker) throws Exception {
         PROPERTY: for (Map.Entry<Property, PropertyVersions> entry : getHelper().getVersionPropertiesMap(VersionsHelper.VersionPropertiesMapRequest.builder().withMavenProject(getProject()).build()).entrySet()) {
             Property property = entry.getKey();
             String name = property.getName();