Merge pull request #406 from fo-code/delta-api-extension

Expanded code delta API

Author: uhafner

pom.xml

@@ -170,6 +170,12 @@
                   <classSimpleName>Change</classSimpleName>
                   <justification>This API is not finally in use yet.</justification>
                 </item>
+                <item>
+                  <code>java.method.abstractMethodAdded</code>
+                  <classSimpleName>DeltaCalculator</classSimpleName>
+                  <method>calculateDelta</method>
+                  <justification>The new method is required when no commit IDs are accessible.</justification>
+                </item>
               </differences>
             </revapi.differences>
           </analysisConfiguration>

src/main/java/io/jenkins/plugins/forensics/delta/DeltaCalculator.java

@@ -5,6 +5,8 @@
 
 import edu.hm.hafner.util.FilteredLog;
 
+import hudson.model.Run;
+
 import io.jenkins.plugins.forensics.delta.model.Delta;
 
 /**
@@ -31,6 +33,21 @@ public abstract class DeltaCalculator implements Serializable {
     public abstract Optional<Delta> calculateDelta(String currentCommitId, String referenceCommitId,
             FilteredLog logger);
 
+    /**
+     * Calculates the {@link Delta} between two passed Jenkins builds.
+     *
+     * @param build
+     *         The currently processed build
+     * @param referenceBuild
+     *         The reference build
+     * @param logger
+     *         The used log
+     *
+     * @return the delta if it could be calculated
+     */
+    public abstract Optional<Delta> calculateDelta(Run<?, ?> build, Run<?, ?> referenceBuild,
+            FilteredLog logger);
+
     /**
      * A delta calculator that does nothing.
      */
@@ -43,5 +60,11 @@ public Optional<Delta> calculateDelta(final String currentCommitId, final String
                 final FilteredLog logger) {
             return Optional.empty();
         }
+
+        @Override
+        public Optional<Delta> calculateDelta(final Run<?, ?> build, final Run<?, ?> referenceBuild,
+                final FilteredLog logger) {
+            return Optional.empty();
+        }
     }
 }

src/test/java/io/jenkins/plugins/forensics/delta/DeltaCalculatorFactoryITest.java

@@ -50,6 +50,7 @@ public void shouldSelectNullDeltaCalculator() {
 
         assertThat(nullCalculator).isInstanceOf(NullDeltaCalculator.class);
         assertThat(nullCalculator.calculateDelta("", "", log)).isEmpty();
+        assertThat(nullCalculator.calculateDelta(mock(Run.class), mock(Run.class), log)).isEmpty();
         assertThat(log.getInfoMessages()).containsOnly(NO_SUITABLE_DELTA_CALCULATOR_FOUND,
                 ACTUAL_FACTORY_NULL_DELTA_CALCULATOR, EMPTY_FACTORY_NULL_DELTA_CALCULATOR);
         assertThat(log.getErrorMessages()).isEmpty();
@@ -104,6 +105,12 @@ public Optional<Delta> calculateDelta(final String currentCommitId, final String
                 final FilteredLog logger) {
             return Optional.empty();
         }
+
+        @Override
+        public Optional<Delta> calculateDelta(final Run<?, ?> build, final Run<?, ?> referenceBuild,
+                final FilteredLog logger) {
+            return Optional.empty();
+        }
     }
 
     /**