Do not use source when initialROwCount is used for a Simple TableView

boutinb · JorisGoosen · commit 4c65a9de3aeb · 2025-09-09T12:36:21.000+02:00
diff --git a/QMLComponents/controls/tableviewbase.cpp b/QMLComponents/controls/tableviewbase.cpp
@@ -49,6 +49,10 @@ void TableViewBase::setUpModel()
 	case ModelType::Simple					: _tableModel = new ListModelTableViewBase(			this );	break;
 	}
 
+	if (modelType() == ModelType::Simple &&_initialRowCount > 0)
+		// Per default the rows are set by the source, and if no source is specified, it sets automatically the dataset as source.
+		// But if initialRowCount is used, it means that this table sets its own rows, so no source is needed.
+		_tableModel->setNeedsSource(false);
 	JASPListControl::setUpModel();
 
 	connect(_tableModel, &ListModelTableViewBase::columnCountChanged,	this, &TableViewBase::columnCountChanged);

Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,10 @@ void TableViewBase::setUpModel()`
`49`	`49`	`case ModelType::Simple : _tableModel = new ListModelTableViewBase( this ); break;`
`50`	`50`	`}`
`51`	`51`
	`52`	`+ if (modelType() == ModelType::Simple &&_initialRowCount > 0)`
	`53`	`+ // Per default the rows are set by the source, and if no source is specified, it sets automatically the dataset as source.`
	`54`	`+ // But if initialRowCount is used, it means that this table sets its own rows, so no source is needed.`
	`55`	`+ _tableModel->setNeedsSource(false);`
`52`	`56`	`JASPListControl::setUpModel();`
`53`	`57`
`54`	`58`	`connect(_tableModel, &ListModelTableViewBase::columnCountChanged, this, &TableViewBase::columnCountChanged);`