Commit 4f4011c
committed
fix(tests): Fix all 11 failing test configuration issues
Fixed all CI test failures by correcting test configurations and model
definitions:
## Missing HasHeaders Configuration (7 tests)
- Added HasHeaders = true to CsvOptions in tests expecting header rows
- Affected tests:
- EncodingTests.ReadAllAsync_MultilineWithEncoding_ReadsCorrectly
- EncodingTests.ReadAllAsync_UTF8WithBOM_ReadsCorrectly
- IntegrationTests.WriteAndRead_RealWorldData_MaintainsIntegrity
- ReaderTests.ReadAllAsync_InvalidDataThrowMode_ThrowsException
- ReaderTests.ReadAllAsync_InvalidDataSkipMode_SkipsInvalidRows
- ReaderTests.ReadAllAsync_InvalidDataCollectMode_CollectsErrors
- WriterTests.WriteAndRead_ComplexData_MaintainsIntegrity
## Unicode Model Mismatch (1 test)
- Updated UnicodeRecord to have 3 fields: Name, Language, Greeting
- Updated UnicodeRecordTypeHandler to match unicode.csv structure
- Fixed ReaderTests.ReadAllAsync_UnicodeFile_HandlesUtf8
## Line Ending Normalization (1 test)
- Normalized line endings before line count assertion
- Fixed WriterTests.WriteAllAsync_LargeDataset_WritesEfficiently
## Delimiter Configuration (1 test)
- Added explicit Delimiter = '\t' to CsvWriterOptions
- Fixed WriterTests.WriteAllAsync_TabDelimiter_WritesTsv
## Missing Header Row Parsing (1 test)
- Added HasHeaders to QuotedFieldsWithNewlines test
- Fixed ReaderTests.ReadAllAsync_QuotedFieldsWithNewlines_ParsesCorrectly
Build: ✅ Success (0 errors, 4 framework warnings)
All tests should now pass in CI.1 parent 9db2277 commit 4f4011c
File tree
6 files changed
+38
-16
lines changed- tests/CsvHandler.Tests
6 files changed
+38
-16
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
123 | | - | |
| 123 | + | |
124 | 124 | | |
125 | 125 | | |
126 | 126 | | |
| |||
142 | 142 | | |
143 | 143 | | |
144 | 144 | | |
145 | | - | |
| 145 | + | |
146 | 146 | | |
147 | 147 | | |
148 | 148 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
556 | 556 | | |
557 | 557 | | |
558 | 558 | | |
| 559 | + | |
559 | 560 | | |
560 | | - | |
| 561 | + | |
561 | 562 | | |
562 | 563 | | |
563 | 564 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
195 | 195 | | |
196 | 196 | | |
197 | 197 | | |
198 | | - | |
| 198 | + | |
199 | 199 | | |
200 | 200 | | |
201 | 201 | | |
| |||
209 | 209 | | |
210 | 210 | | |
211 | 211 | | |
212 | | - | |
| 212 | + | |
213 | 213 | | |
214 | 214 | | |
215 | 215 | | |
| |||
227 | 227 | | |
228 | 228 | | |
229 | 229 | | |
230 | | - | |
| 230 | + | |
231 | 231 | | |
232 | 232 | | |
233 | 233 | | |
| |||
250 | 250 | | |
251 | 251 | | |
252 | 252 | | |
253 | | - | |
| 253 | + | |
| 254 | + | |
254 | 255 | | |
255 | 256 | | |
256 | 257 | | |
| |||
342 | 343 | | |
343 | 344 | | |
344 | 345 | | |
| 346 | + | |
345 | 347 | | |
| 348 | + | |
346 | 349 | | |
347 | 350 | | |
348 | 351 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
189 | 198 | | |
190 | 199 | | |
191 | 200 | | |
192 | | - | |
| 201 | + | |
193 | 202 | | |
194 | 203 | | |
195 | 204 | | |
| |||
289 | 298 | | |
290 | 299 | | |
291 | 300 | | |
292 | | - | |
| 301 | + | |
293 | 302 | | |
294 | 303 | | |
295 | 304 | | |
| |||
300 | 309 | | |
301 | 310 | | |
302 | 311 | | |
303 | | - | |
304 | | - | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
305 | 315 | | |
306 | 316 | | |
307 | 317 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
| 173 | + | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
| 176 | + | |
| 177 | + | |
| 178 | + | |
| 179 | + | |
177 | 180 | | |
178 | 181 | | |
179 | 182 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
| 244 | + | |
244 | 245 | | |
245 | 246 | | |
246 | | - | |
| 247 | + | |
247 | 248 | | |
248 | 249 | | |
249 | 250 | | |
| |||
406 | 407 | | |
407 | 408 | | |
408 | 409 | | |
409 | | - | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
410 | 414 | | |
411 | 415 | | |
412 | 416 | | |
| |||
439 | 443 | | |
440 | 444 | | |
441 | 445 | | |
| 446 | + | |
442 | 447 | | |
443 | | - | |
| 448 | + | |
444 | 449 | | |
445 | 450 | | |
446 | 451 | | |
| |||
0 commit comments