Google Shell Style Guide: Don't use flags in shebang

jan-revay · jan-revay · commit c069c734abea · 2025-11-26T09:57:27.000+01:00
- set flags in prelude.sh instead
diff --git a/Android_13/10packages.sh b/Android_13/10packages.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # BASE IMAGE Android 13
 
 . ../prelude.sh
diff --git a/Android_13/20configs.sh b/Android_13/20configs.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # BASE IMAGE: Android 13
 
 . ../prelude.sh
diff --git a/Android_13/run_all.sh b/Android_13/run_all.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # BASE IMAGE: Android 13
 
 . ../prelude.sh
diff --git a/CLI_Ubuntu/10interactive.sh b/CLI_Ubuntu/10interactive.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # Stuff that requires user interaction and cannot be done by a script yet.
 # This script is being run first i.e. before anything else, so that all
 # user interaction is finished as quickly as possible.
diff --git a/CLI_Ubuntu/20packages.sh b/CLI_Ubuntu/20packages.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # The script should not require any user input and should be idempotent.
 # TODO apt-get install linux-headers-$(uname -r) does not work in WSL
 # TODO move the package lists to external files
diff --git a/CLI_Ubuntu/30source_packages.sh b/CLI_Ubuntu/30source_packages.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # The script should not require any user input and should be idempotent.
 # TODO apt-get install linux-headers-$(uname -r) does not work in WSL
 # TODO move the package lists to external files
diff --git a/CLI_Ubuntu/40configs.sh b/CLI_Ubuntu/40configs.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # The script should not require any user input and should be idempotent.
 
 . ../prelude.sh
diff --git a/CLI_Ubuntu/run_all.sh b/CLI_Ubuntu/run_all.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # This script should be idempotent.
 
 . ../prelude.sh
diff --git a/DistroAgnostic/10dotfiles.sh b/DistroAgnostic/10dotfiles.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # The script should not require any user input and should be idempotent.
 # BASE IMAGE: ALL
 # Dotfiles are managed via bare git repository.
diff --git a/DistroAgnostic/20git_config.sh b/DistroAgnostic/20git_config.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 
 . ../prelude.sh
 
diff --git a/DistroAgnostic/30git_hooks.sh b/DistroAgnostic/30git_hooks.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # WARNING: this scripts expects ./DistroAgnostic as a working directory
 
 # TODO rename to snake case shared_configs_install.sh
diff --git a/DistroAgnostic/40mkdirs.sh b/DistroAgnostic/40mkdirs.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # The script should not require any user input and should be idempotent.
 
 . ../prelude.sh
diff --git a/DistroAgnostic/gnome/10flatpaks_snaps_appimages_nix.sh b/DistroAgnostic/gnome/10flatpaks_snaps_appimages_nix.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 
 . ../../prelude.sh
 
diff --git a/DistroAgnostic/gnome/20gnome_install_extensions.sh b/DistroAgnostic/gnome/20gnome_install_extensions.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # This script should be idempotent.
 # This script REQUIRES USER INTERACTION IN GNOME!!!
 #
diff --git a/DistroAgnostic/gnome/30gsettings.sh b/DistroAgnostic/gnome/30gsettings.sh
@@ -1,4 +1,5 @@
-#!/bin/bash -x
+#!/bin/bash
+. ../../prelude.sh
 
 # HOW TO WATCH GSettings changes on Ubuntu? Run `dconf watch /`
 # NOTE: for_each blocks are sorted by path alphabetically (their content and blocks themselves)
@@ -13,7 +14,6 @@
 # https://docs.gtk.org/gio/class.Settings.html
 # https://wiki.gnome.org/HowDoI/GSettings
 
-. ../../prelude.sh
 
 # disable-lock-screen was set to true for some reason on my fresh Ubuntu 24.04 install
 gsettings set org.gnome.desktop.lockdown disable-lock-screen false
diff --git a/DistroAgnostic/gnome/40extensions_gsettings.sh b/DistroAgnostic/gnome/40extensions_gsettings.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 
 . ../../prelude.sh
 
diff --git a/DistroAgnostic/run_all.sh b/DistroAgnostic/run_all.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # This script should be idempotent.
 
 . ../prelude.sh
diff --git a/MacOS/packages_install.sh b/MacOS/packages_install.sh
@@ -1,4 +1,6 @@
-#!/bin/bash -x
+#!/bin/bash
+. ../prelude.sh
+
 
 # TODO       - name: Make script executable
 #        run: chmod +x ./MacOS/packages_install.sh
diff --git a/PopOS_22.04_deprecated/configs_install.sh b/PopOS_22.04_deprecated/configs_install.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # shellcheck disable=SC2317
 # WARNING: this script is not uptodate and also does not work - has a lot of bugs
 # it is more of an WIP record of TODOs and stubs than something usable
diff --git a/PopOS_22.04_deprecated/packages_install.sh b/PopOS_22.04_deprecated/packages_install.sh
@@ -1,4 +1,5 @@
-#!/bin/bash -x
+#!/bin/bash
+. ../prelude.sh
 
 # TODO
 # - Docker
@@ -12,7 +13,6 @@
 # - test & tune this on a virtual machine so that no user input is required
 # - use WSL Ubuntu as a base layer
 
-. ../prelude.sh
 
 readonly LLVM_VERSION=16 # CURRENT_LLVM_STABLE
 readonly GCC_VERSION=13  # CURRENT_GCC_STABLE
diff --git a/PopOS_22.04_deprecated/run_all.sh b/PopOS_22.04_deprecated/run_all.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # This script should be idempotent.
 # shellcheck disable=SC2317  # Don't warn about unreachable commands in this file
 
diff --git a/Ubuntu/10packages.sh b/Ubuntu/10packages.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # The script should not require any user input and should be idempotent.
 
 # TODO use lists for packages (and use on install command)
diff --git a/Ubuntu/20configs.sh b/Ubuntu/20configs.sh
@@ -1,4 +1,6 @@
-#!/bin/bash -x
+#!/bin/bash
+. ../prelude.sh
+
 # The script should not require any user input and should be idempotent.
 
 # Workflow: use `dconf watch /`, make the change via GUI,
@@ -16,7 +18,6 @@
 
 # TODO pohrat sa s tymi nastaveniami, ci vlastne su vsetky potrebne a robia to co chcem
 
-. ../prelude.sh
 
 # GNOME TWEAKS
 
diff --git a/Ubuntu/run_all.sh b/Ubuntu/run_all.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # This script should be idempotent.
 
 . ../prelude.sh
diff --git a/pre-commit-hook.sh b/pre-commit-hook.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # TODO precommit hooks WIP
 
 . prelude.sh
diff --git a/prelude.sh b/prelude.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 
 # TODO make this into the library so that the
 # testing of distro version can be used in if/else
diff --git a/run_init.sh b/run_init.sh
@@ -1,4 +1,4 @@
-#!/bin/bash -x
+#!/bin/bash
 # Automatically detect and init/configure the host platform.
 
 . prelude.sh

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-#!/bin/bash -x`
	`1`	`+#!/bin/bash`
`2`	`2`	`# BASE IMAGE Android 13`
`3`	`3`
`4`	`4`	`. ../prelude.sh`