Skip to content

Commit d53dc1b

Browse files
chitrangpateltekton-robot
authored andcommitted
valid config file test case added
1 parent 6a17fa1 commit d53dc1b

File tree

3 files changed

+39
-1
lines changed

3 files changed

+39
-1
lines changed

docs/install.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -500,7 +500,11 @@ kubectl patch cm feature-flags -n tekton-pipelines -p '{"data":{"results-from":"
500500
```
501501
502502
3. If you want the size per result to be something other than 4096 bytes, you can set the `max-result-size` feature flag in bytes by setting `max-result-size: 8192(whatever you need here)`. **Note:** The value you can set here cannot exceed the size of the CRD limit of 1.5 MB.
503-
503+
504+
```
505+
kubectl patch cm feature-flags -n tekton-pipelines -p '{"data":{"max-result-size":"<VALUE-IN-BYTES>"}}'
506+
```
507+
504508
## Configuring High Availability
505509
506510
If you want to run Tekton Pipelines in a way so that webhooks are resiliant against failures and support

pkg/apis/config/feature_flags_test.go

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -144,6 +144,18 @@ func TestNewFeatureFlagsFromConfigMap(t *testing.T) {
144144
},
145145
fileName: "feature-flags-enable-spire",
146146
},
147+
{
148+
expectedConfig: &config.FeatureFlags{
149+
EnableAPIFields: "stable",
150+
EmbeddedStatus: "full",
151+
ResourceVerificationMode: config.DefaultResourceVerificationMode,
152+
RunningInEnvWithInjectedSidecars: config.DefaultRunningInEnvWithInjectedSidecars,
153+
AwaitSidecarReadiness: config.DefaultAwaitSidecarReadiness,
154+
ResultExtractionMethod: config.ResultExtractionMethodSidecarLogs,
155+
MaxResultSize: 8192,
156+
},
157+
fileName: "feature-flags-results-via-sidecar-logs",
158+
},
147159
}
148160

149161
for _, tc := range testCases {
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Copyright 2021 The Tekton Authors
2+
#
3+
# Licensed under the Apache License, Version 2.0 (the "License");
4+
# you may not use this file except in compliance with the License.
5+
# You may obtain a copy of the License at
6+
#
7+
# https://www.apache.org/licenses/LICENSE-2.0
8+
#
9+
# Unless required by applicable law or agreed to in writing, software
10+
# distributed under the License is distributed on an "AS IS" BASIS,
11+
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
12+
# See the License for the specific language governing permissions and
13+
# limitations under the License.
14+
15+
apiVersion: v1
16+
kind: ConfigMap
17+
metadata:
18+
name: feature-flags
19+
namespace: tekton-pipelines
20+
data:
21+
results-from: "sidecar-logs"
22+
max-result-size: 8192

0 commit comments

Comments
 (0)