Skip to content

Commit 7e5e7d5

Browse files
authored
fix: Update milvus connect function to work with remote instance (feast-dev#5382)
1 parent 3e5793b commit 7e5e7d5

File tree

1 file changed

+6
-3
lines changed
  • sdk/python/feast/infra/online_stores/milvus_online_store

1 file changed

+6
-3
lines changed

sdk/python/feast/infra/online_stores/milvus_online_store/milvus.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ class MilvusOnlineStoreConfig(FeastConfigBaseModel, VectorStoreConfig):
8888
"""
8989

9090
type: Literal["milvus"] = "milvus"
91-
path: Optional[StrictStr] = "online_store.db"
91+
path: Optional[StrictStr] = ""
9292
host: Optional[StrictStr] = "localhost"
9393
port: Optional[int] = 19530
9494
index_type: Optional[str] = "FLAT"
@@ -126,13 +126,16 @@ def _get_db_path(self, config: RepoConfig) -> str:
126126

127127
def _connect(self, config: RepoConfig) -> MilvusClient:
128128
if not self.client:
129-
if config.provider == "local":
129+
if config.provider == "local" and config.online_store.path:
130130
db_path = self._get_db_path(config)
131131
print(f"Connecting to Milvus in local mode using {db_path}")
132132
self.client = MilvusClient(db_path)
133133
else:
134+
print(
135+
f"Connecting to Milvus remotely at {config.online_store.host}:{config.online_store.port}"
136+
)
134137
self.client = MilvusClient(
135-
url=f"{config.online_store.host}:{config.online_store.port}",
138+
uri=f"{config.online_store.host}:{config.online_store.port}",
136139
token=f"{config.online_store.username}:{config.online_store.password}"
137140
if config.online_store.username and config.online_store.password
138141
else "",

0 commit comments

Comments
 (0)