Skip to content

Commit 5fb8986

Browse files
authored
bench: check for dvc_bin.version instead of dvc_rev (#10764)
* bench: check for dvc_bin.version instead of dvc_rev * Update dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py * Update dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py
1 parent 18177a6 commit 5fb8986

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,12 @@
33
from packaging import version
44

55

6-
def test_sharing(bench_dvc, tmp_dir, dvc, make_dataset, remote, dvc_rev):
6+
def test_sharing(bench_dvc, tmp_dir, dvc, make_dataset, remote, dvc_bin):
77
is_gs = dvc.config["remote"]["upstream"]["url"].startswith("gs://")
8-
if dvc_rev and is_gs and version.Version(dvc_rev) < version.Version("3.59.3"):
9-
# support for allow_anonymous_login in gs was introduced in dvc==3.59.3
8+
if is_gs and version.Version(dvc_bin.version) < version.Version("3.59.2"):
9+
# support for allow_anonymous_login in gs was introduced in dvc==3.60
10+
# This should not impact the test, just that it will make it slower if used
11+
# with fake-gcs-server.
1012
with dvc.config.edit() as d:
1113
d["remote"]["upstream"].pop("allow_anonymous_login", None)
1214

pyproject.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -173,6 +173,7 @@ filterwarnings = [
173173
"ignore:nx.nx_pydot.* depends on the pydot package, which has.*known issues and is not actively maintained:DeprecationWarning",
174174
# TODO: investigate where we are not closing sqlite3.Connection
175175
"ignore:unclosed database.*sqlite3.Connection:ResourceWarning",
176+
"ignore:unclosed.*<socket.socket:ResourceWarning",
176177
]
177178
log_level = "debug"
178179
markers = [

0 commit comments

Comments
 (0)