chore(GH-1280): fix PHP 8.4 compatibility issues in zmsdb tests and SlotList

- Fix writeByAvailability method calls in SlotTest to include required third parameter
- Add explicit nullable types to SlotList constructor and getFreeProcesses method parameters
- Resolve PHP 8.4 deprecation warnings about implicitly nullable parameters

Author: ThomasAFink

zmsdb/src/Zmsdb/Query/SlotList.php

@@ -178,11 +178,11 @@ class SlotList extends Base
 
     public function __construct(
         array $slotData = ['availability__id' => null],
-        \DateTimeImmutable $start = null,
-        \DateTimeImmutable $stop = null,
-        \DateTimeInterface $now = null,
-        \BO\Zmsentities\Availability $availability = null,
-        \BO\Zmsentities\Scope $scope = null
+        ?\DateTimeImmutable $start = null,
+        ?\DateTimeImmutable $stop = null,
+        ?\DateTimeInterface $now = null,
+        ?\BO\Zmsentities\Availability $availability = null,
+        ?\BO\Zmsentities\Scope $scope = null
     ) {
         $this->availability = $availability;
         $this->scope = $scope;
@@ -353,7 +353,7 @@ protected function addFreeProcessesToCalendar(
      */
     public function getFreeProcesses(
         \BO\Zmsentities\Calendar $calendar,
-        \DateTimeImmutable $freeProcessesDate = null,
+        ?\DateTimeImmutable $freeProcessesDate = null,
         $slotType = 'public',
         $slotsRequired = 1
     ) {

zmsdb/tests/Zmsdb/SlotTest.php

@@ -276,7 +276,7 @@ public function testNoChangeIntegration()
     {
         $availability = $this->readTestAvailability();
         $now = (new Slot())->readLastChangedTimeByAvailability($availability);
-        $status = (new Slot())->writeByAvailability($availability, $now);
+        $status = (new Slot())->writeByAvailability($availability, $now, $now);
         $this->assertFalse($status, "Availability should not rebuild slots without change");
     }
 
@@ -286,7 +286,7 @@ public function testChangedScopeIntegration()
         $availability->scope['preferences']['appointment']['endInDaysDefault'] = 63;
         $availability->scope = (new \BO\Zmsdb\Scope())->updateEntity($availability->scope->id, $availability->scope, 1);
         $now = (new Slot())->readLastChangedTimeByAvailability($availability);
-        $status = (new Slot())->writeByAvailability($availability, $now);
+        $status = (new Slot())->writeByAvailability($availability, $now, $now);
         //$this->debugOutdated($availability, $now, $now->modify('-1 hour'));
         $this->assertFalse(!$status, "Availability should rebuild slots on changed scope");
     }
@@ -315,21 +315,21 @@ public function testChangeOnCancel()
             $lastChange->format('Y-m-d H:i:s'),
             "readLastChangedTimeByAvailability should not return cancelled slots"
         );
-        $status = (new Slot())->writeByAvailability($availability, $now);
+        $status = (new Slot())->writeByAvailability($availability, $now, $now);
         $this->assertFalse(!$status, "Availability should rebuild slots if newer");
     }
 
     public function testChangeByTimeIntegration()
     {
         $availability = $this->readTestAvailability();
         $lastChange = (new Slot())->readLastChangedTimeByAvailability($availability);
-        $status = (new Slot())->writeByAvailability($availability, static::$now);
+        $status = (new Slot())->writeByAvailability($availability, static::$now, static::$now);
         //$this->debugOutdated($availability, $now, $lastChange);
         $availability = $this->readTestAvailability();
         $now = (new Slot())->readLastChangedTimeByAvailability($availability);
         $lastChange = $now;
         $now = $now->modify('+1 day');
-        $status = (new Slot())->writeByAvailability($availability, $now);
+        $status = (new Slot())->writeByAvailability($availability, $now, $now);
         //$this->debugOutdated($availability, $now, $lastChange);
 
         $this->assertFalse(!$status, "Availability should rebuild slots if time allows new slots");
@@ -463,7 +463,7 @@ public function testChangeOnCancelSameDay()
         $this->assertEquals('cancelled', $cancelledSlots[0]['status'], "Slots should be cancelled before the cancellation time");
 
         // Verify we don't rebuild slots
-        $status = (new Slot())->writeByAvailability($availability, $now);
+        $status = (new Slot())->writeByAvailability($availability, $now, $now);
         $this->assertFalse($status, "Availability should not rebuild slots when Offen_ab=0 Offen_bis=0 and slots are cancelled");
 
         // Verify slots remain cancelled
@@ -505,7 +505,7 @@ public function testChangeOnCancelDifferentDay()
             $lastChange->format('Y-m-d H:i:s'),
             "readLastChangedTimeByAvailability should not return cancelled slots"
         );
-        $status = (new Slot())->writeByAvailability($availability, $now);
+        $status = (new Slot())->writeByAvailability($availability, $now, $now);
         $this->assertFalse($status, "Availability should not rebuild slots when cancellation is not on same day as Offen_ab=0 Offen_bis=0");
     }