slack: notification error log

viktor-kurchenko · viktor-kurchenko · commit 3ab8d241d3fe · 2025-01-29T10:49:42.000+01:00
The commit improves log during notification error.

Signed-off-by: viktor-kurchenko &lt;viktor.kurchenko@isovalent.com&gt;
diff --git a/pkg/slack/slack.go b/pkg/slack/slack.go
@@ -7,6 +7,8 @@ import (
 	"time"
 	"unicode/utf8"
 
+	"c7n-helper/pkg/log"
+
 	"github.com/slack-go/slack"
 )
 
@@ -162,6 +164,7 @@ func (s *slackProvider) notify(ctx context.Context, channelMessages map[string][
 		for _, message := range messages {
 			_, _, _, err := s.client.SendMessageContext(ctx, channel, slack.MsgOptionText(message, false))
 			if err != nil {
+				log.FromContext(ctx).Errorf("channel [%s] notification error (check if C7N bot invited!): %s", channel, err)
 				return err
 			}
 			time.Sleep(time.Millisecond * 150) // pause to avoid slack rate limits

Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,8 @@ import (`
`7`	`7`	`"time"`
`8`	`8`	`"unicode/utf8"`
`9`	`9`
	`10`	`+ "c7n-helper/pkg/log"`
	`11`	`+`
`10`	`12`	`"github.com/slack-go/slack"`
`11`	`13`	`)`
`12`	`14`
`@@ -162,6 +164,7 @@ func (s *slackProvider) notify(ctx context.Context, channelMessages map[string][`
`162`	`164`	`for _, message := range messages {`
`163`	`165`	`_, _, _, err := s.client.SendMessageContext(ctx, channel, slack.MsgOptionText(message, false))`
`164`	`166`	`if err != nil {`
	`167`	`+ log.FromContext(ctx).Errorf("channel [%s] notification error (check if C7N bot invited!): %s", channel, err)`
`165`	`168`	`return err`
`166`	`169`	`}`
`167`	`170`	`time.Sleep(time.Millisecond * 150) // pause to avoid slack rate limits`