-
Notifications
You must be signed in to change notification settings - Fork 4
chore: fix a few typos #336
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Gaurav Gahlot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects several typos throughout the codebase, improving code clarity and documentation accuracy. The changes fix misspellings of "Bootstrap" (previously "Boostrap") in function names, variables, and comments, as well as correcting "matche" to "match" in a test comment and "importas" to "imports" in documentation.
Key changes:
- Fixed "Boostrap" typo to "Bootstrap" in function name, variable names, and struct field
- Corrected comment typos in test file and style guide documentation
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| scope/machine.go | Corrected function name from "GetBoostrapDataSecret" to "GetBootstrapDataSecret" |
| internal/service/cloud/server.go | Fixed struct field and variable names from "boostrapData" to "bootstrapData" |
| internal/service/cloud/image_test.go | Corrected comment from "partial matche" to "partial match" |
| docs/style-guide.md | Fixed linter name reference from "importas" to "imports" |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
| - Use camel-case with capital letters for acronyms, e.g. HTTP, API, etc. | ||
| - Import names and aliases SHOULD be precise. v1 isn't. E.g. in the context of K8s, we use corev1, metav1, appsv1 etc. | ||
| - Be consistent here, too: Match parameters and type names at package level, e.g. single name for a client parameter across different functions. Match import aliases across files and preferably across the whole project. The importas linter can be used to enforce this. | ||
| - Be consistent here, too: Match parameters and type names at package level, e.g. single name for a client parameter across different functions. Match import aliases across files and preferably across the whole project. The imports linter can be used to enforce this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
importas was correct:
| - importas |
Maybe add backticks around it. Actually this whole file could need some more backticks.



What is the purpose of this pull request/Why do we need it?
Fixing a few typos.
Issue #, if available:
Description of changes:
Special notes for your reviewer:
Checklist: