Use XOR

Author: gfariasalves-ionos

api/v1alpha1/ionoscloudmachine_types.go

@@ -234,7 +234,7 @@ type Volume struct {
 	AvailabilityZone AvailabilityZone `json:"availabilityZone,omitempty"`
 
 	// Image is the image to use for the VM.
-	//+kubebuilder:validation:XValidation:rule="self.id != '' || has(self.selector)",message="must provide either id or selector"
+	//+kubebuilder:validation:XValidation:rule="has(self.id) && !has(self.selector) || !has(self.id) && has(self.selector)",message="must provide either id or selector"
 	Image *ImageSpec `json:"image"`
 }
 

api/v1alpha1/ionoscloudmachine_types_test.go

@@ -352,6 +352,16 @@ var _ = Describe("IonosCloudMachine Tests", func() {
 					Expect(m.Spec.Disk.Image.Selector.UseMachineVersion).ToNot(BeNil())
 					Expect(*m.Spec.Disk.Image.Selector.UseMachineVersion).To(BeTrue())
 				})
+				It("should fail if both ID and selector are set", func() {
+					m := defaultMachine()
+					m.Spec.Disk.Image.ID = "1eef-48ec-a246-a51a33aa4f3a"
+					m.Spec.Disk.Image.Selector = &ImageSelector{
+						MatchLabels: map[string]string{
+							"foo": "bar",
+						},
+					}
+					Expect(k8sClient.Create(context.Background(), m)).ToNot(Succeed())
+				})
 			})
 		})
 		Context("Additional Networks", func() {

config/crd/bases/infrastructure.cluster.x-k8s.io_ionoscloudmachines.yaml

@@ -235,7 +235,8 @@ spec:
                     type: object
                     x-kubernetes-validations:
                     - message: must provide either id or selector
-                      rule: self.id != '' || has(self.selector)
+                      rule: has(self.id) && !has(self.selector) || !has(self.id) &&
+                        has(self.selector)
                   name:
                     description: Name is the name of the volume
                     type: string

config/crd/bases/infrastructure.cluster.x-k8s.io_ionoscloudmachinetemplates.yaml

@@ -256,7 +256,8 @@ spec:
                             type: object
                             x-kubernetes-validations:
                             - message: must provide either id or selector
-                              rule: self.id != '' || has(self.selector)
+                              rule: has(self.id) && !has(self.selector) || !has(self.id)
+                                && has(self.selector)
                           name:
                             description: Name is the name of the volume
                             type: string