🐳 Unused assignment、Non-distinguishable logging calls

Author: iohao

net-bolt/bolt-core/src/main/java/com/iohao/game/bolt/broker/core/client/BrokerClientManager.java

@@ -20,23 +20,19 @@
 
 import com.alipay.remoting.ConnectionEventProcessor;
 import com.alipay.remoting.ConnectionEventType;
-import com.alipay.remoting.rpc.RpcClient;
 import com.alipay.remoting.rpc.protocol.UserProcessor;
 import com.iohao.game.action.skeleton.core.BarSkeleton;
 import com.iohao.game.bolt.broker.core.common.IoGameGlobalConfig;
 import com.iohao.game.bolt.broker.core.loadbalance.ElementSelector;
 import com.iohao.game.bolt.broker.core.loadbalance.ElementSelectorFactory;
 import com.iohao.game.bolt.broker.core.loadbalance.RandomElementSelector;
-import com.iohao.game.common.kit.concurrent.TaskKit;
 import lombok.Getter;
 import lombok.Setter;
 import lombok.experimental.Accessors;
 import lombok.extern.slf4j.Slf4j;
 import org.jctools.maps.NonBlockingHashMap;
 
 import java.util.*;
-import java.util.concurrent.TimeUnit;
-import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.function.Consumer;
 import java.util.function.Supplier;
 
@@ -127,17 +123,8 @@ public void remove(String address) {
 
         if (IoGameGlobalConfig.openLog) {
             Set<String> keySet = brokerClientItemMap.keySet();
-            log.info("当前网关数量 : {} {}", this.brokerClientItemMap.size(), keySet);
-        }
-    }
-
-    private void a() {
-        AtomicBoolean flag = new AtomicBoolean();
-        if (flag.compareAndSet(false, true)) {
-            TaskKit.runInterval(() -> {
-                Set<String> keySet = brokerClientItemMap.keySet();
-                log.info("当前网关数量 : {} {}", this.brokerClientItemMap.size(), keySet);
-            }, 5, TimeUnit.SECONDS);
+            String message = "当前网关数量 : %s {}".formatted(this.brokerClientItemMap.size());
+            log.info(message, keySet);
         }
     }
 

widget/light-client/src/main/java/com/iohao/game/external/client/InputCommandCreate.java

@@ -124,8 +124,7 @@ public InputCommand ofInputCommandUserId(int subCmd) {
 
     public RequestDataDelegate nextParamLong(String paramTips) {
         return () -> {
-            String info = "请输入{} | 参数类型 : {}";
-            log.info(info, paramTips, long.class);
+            log.info("请输入{} | 参数类型 : long.class", paramTips);
 
             long longValue = ScannerKit.nextLong();
             return LongValue.of(longValue);

widget/light-redis-lock-spring-boot-starter/src/main/java/com/iohao/game/widget/light/redis/lock/spring/service/service/DefaultRedissonDistributedLock.java

@@ -35,7 +35,6 @@ public <T> T tryLockAndExecute(String key, long waitTime, long leaseTime, TimeUn
         try {
             boolean tryLock = lock.tryLock(waitTime, leaseTime, unit);
             if (tryLock) {
-                log.info("{} 获取锁成功", key);
                 return action.execute();
             }
         } finally {
@@ -52,10 +51,7 @@ public void tryLockAndExecute(String key, long waitTime, long leaseTime, TimeUni
         try {
             boolean tryLock = lock.tryLock(waitTime, leaseTime, unit);
             if (tryLock) {
-                log.info("{} 获取锁成功", key);
                 action.execute();
-            } else {
-                log.info("{} 获取锁超时", key);
             }
         } finally {
             if (lock.isHeldByCurrentThread()) {
@@ -69,7 +65,6 @@ public <T> T lockAndExecute(String key, long leaseTime, TimeUnit unit, ReturnHan
         RLock lock = redissonClient.getLock(key);
         try {
             lock.lock(leaseTime, unit);
-            log.info("{} 获取锁成功", key);
             return action.execute();
         } finally {
             if (lock.isHeldByCurrentThread()) {
@@ -83,7 +78,6 @@ public void lockAndExecute(String key, long leaseTime, TimeUnit unit, VoidHandle
         RLock lock = redissonClient.getLock(key);
         try {
             lock.lock(leaseTime, unit);
-            log.info("{} 获取锁成功", key);
             action.execute();
         } finally {
             if (lock.isHeldByCurrentThread()) {

widget/light-redis-lock/src/main/java/com/iohao/game/widget/light/redis/lock/DefaultRedissonDistributedLock.java

@@ -7,7 +7,6 @@
 
 import java.util.concurrent.TimeUnit;
 
-
 /**
  * 简单的基于Redisson分布式锁接口实现类
  * <pre>
@@ -47,10 +46,7 @@ public void tryLockAndExecute(String key, long waitTime, long leaseTime, TimeUni
         try {
             boolean tryLock = lock.tryLock(waitTime, leaseTime, unit);
             if (tryLock) {
-                log.info("{} 获取锁成功", key);
                 action.execute();
-            } else {
-                log.info("{} 获取锁超时", key);
             }
         } finally {
             if (lock.isHeldByCurrentThread()) {
@@ -64,7 +60,6 @@ public <T> T lockAndExecute(String key, long leaseTime, TimeUnit unit, ReturnHan
         RLock lock = redissonClient.getLock(key);
         try {
             lock.lock(leaseTime, unit);
-            log.info("{} 获取锁成功", key);
             return action.execute();
         } finally {
             if (lock.isHeldByCurrentThread()) {
@@ -78,7 +73,6 @@ public void lockAndExecute(String key, long leaseTime, TimeUnit unit, VoidHandle
         RLock lock = redissonClient.getLock(key);
         try {
             lock.lock(leaseTime, unit);
-            log.info("{} 获取锁成功", key);
             action.execute();
         } finally {
             if (lock.isHeldByCurrentThread()) {

widget/light-redis-lock/src/main/java/com/iohao/game/widget/light/redis/lock/RedissonConfig.java

@@ -24,7 +24,8 @@ public static class Holder {
     }
 
     public static RedissonClient getRedissonClientFromConfig() {
-        Config config = null;
+        Config config;
+
         try {
             config = Config.fromYAML(RedissonConfig.class.getClassLoader().getResource("redisson-config.yml"));
         } catch (IOException e) {