Skip to content

Commit d19bab7

Browse files
authored
Update analysis options and doc checks for Dart 3.3.0 (#463)
1 parent 33b2216 commit d19bab7

File tree

4 files changed

+228
-160
lines changed

4 files changed

+228
-160
lines changed

.github/configs/mlc_config.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
},
66
{
77
"pattern":"^https://www.intel.com/content/www/us/en/security-center/vulnerability-handling-guidelines.html$"
8+
},
9+
{
10+
"pattern":"^https://stackoverflow.com"
811
}
912
]
1013
}

analysis_options.yaml

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -10,17 +10,17 @@ analyzer:
1010
- doc/tutorials/chapter_9/rohd_vf_example
1111
- rohd_devtools_extension
1212

13-
# keep up to date, matching https://dart-lang.github.io/linter/lints/options/options.html
13+
# keep up to date, matching https://dart.dev/tools/linter-rules/all
1414
# some lints are not yet available, so disabled and marked with [not currently recognized]
1515
linter:
1616
rules:
1717
- always_declare_return_types
1818
- always_put_control_body_on_new_line
1919
- always_put_required_named_parameters_first
20-
- always_require_non_null_named_parameters
2120
# - always_specify_types
2221
- always_use_package_imports
2322
- annotate_overrides
23+
- annotate_redeclares
2424
# - avoid_annotating_with_dynamic
2525
- avoid_bool_literals_in_conditional_expressions
2626
- avoid_catches_without_on_clauses
@@ -46,8 +46,6 @@ linter:
4646
- avoid_relative_lib_imports
4747
- avoid_renaming_method_parameters
4848
- avoid_return_types_on_setters
49-
- avoid_returning_null
50-
- avoid_returning_null_for_future
5149
- avoid_returning_null_for_void
5250
- avoid_returning_this
5351
- avoid_setters_without_getters
@@ -95,15 +93,13 @@ linter:
9593
- implicit_call_tearoffs
9694
- implicit_reopen
9795
- invalid_case_patterns
98-
# - iterable_contains_unrelated_type [deprecated]
9996
- join_return_with_assignment
10097
- leading_newlines_in_multiline_strings
10198
- library_annotations
10299
- library_names
103100
- library_prefixes
104101
- library_private_types_in_public_api
105102
- lines_longer_than_80_chars
106-
# - list_remove_unrelated_type [deprecated]
107103
- literal_only_boolean_expressions
108104
- matching_super_parameters
109105
- missing_whitespace_between_adjacent_strings

tool/gh_actions/check_documentation.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
#!/bin/bash
22

3-
# Copyright (C) 2022-2023 Intel Corporation
3+
# Copyright (C) 2022-2024 Intel Corporation
44
# SPDX-License-Identifier: BSD-3-Clause
55
#
66
# check_documentation.sh
@@ -22,7 +22,7 @@ set -euo pipefail
2222
output=$(dart doc 2>&1 | tee)
2323

2424
# In case of problems, the searched substring will not be found.
25-
if echo "${output}" | grep --silent 'no issues found'; then
25+
if echo "${output}" | grep --silent -e 'no issues found' -e 'Success!'; then
2626
echo 'Documentation check passed!'
2727
else
2828
echo "${output}"

0 commit comments

Comments
 (0)