[Chore] Remove unused iodb (#658)

Author: mirkoAlic

build.sbt

@@ -27,7 +27,6 @@ val dep = {
     "com.typesafe.akka" %% "akka-http-testkit" % akkaHttpVersion % "it,test",
     "io.suzaku" %% "boopickle" % "1.3.0",
     "org.ethereum" % "rocksdbjni" % rocksDb,
-    "org.scorexfoundation" %% "iodb" % "0.3.0",
     "org.scalatest" %% "scalatest" % "3.0.5" % "it,test",
     "org.scalamock" %% "scalamock-scalatest-support" % "3.6.0" % "test",
     "org.scalacheck" %% "scalacheck" % "1.14.0" % "it,test",
@@ -45,8 +44,8 @@ val dep = {
     "org.bouncycastle" % "bcprov-jdk15on" % "1.59",
     "com.typesafe.scala-logging" %% "scala-logging" % "3.9.0",
     "org.typelevel" %% "mouse" % "0.18",
-
     "com.twitter" %% "util-collection" % "18.5.0",
+    "com.google.guava" % "guava" % "28.0-jre",
 
     // mallet deps
     "org.jline" % "jline" % "3.1.2",

src/it/scala/io/iohk/ethereum/db/DataSourceIntegrationTestBehavior.scala

@@ -142,7 +142,7 @@ trait DataSourceIntegrationTestBehavior
           val db = createDataSource(path).update(namespace = OtherNamespace, toRemove = Seq(), toUpsert = keyList.zip(keyList))
           db.destroy()
 
-          assert(!new File("/tmp/iodbDestroy").exists())
+          assert(!new File(path).exists())
 
           val dbAfterDestroy = createDataSource(path)
           keyList.foreach { key => assert(dbAfterDestroy.get(OtherNamespace, key).isEmpty) }

src/it/scala/io/iohk/ethereum/db/IodbDataSourceIntegrationSuite.scala

@@ -442,11 +442,6 @@ mantis {
   }
 
   db {
-    # IODB database is not currently used
-    iodb {
-      path = ${mantis.datadir}"/iodb/"
-    }
-
     rocksdb {
       # RocksDB data directory
       path = ${mantis.datadir}"/rocksdb/"
@@ -477,7 +472,7 @@ mantis {
       block-cache-size = 33554432
     }
 
-    # Define which database to use [rocksdb], iodb is not currently used
+    # Define which database to use [rocksdb]
     data-source = "rocksdb"
   }
 

src/main/resources/application.conf

@@ -55,50 +55,4 @@ object Storages {
 
     }
   }
-
-  /**
-    * As IODB required same length keys, we need a specific storage that pads integer values to be used as keys to match
-    * keccak keys. See [[io.iohk.ethereum.db.storage.IodbBlockNumberMappingStorage]]
-    */
-  trait IodbStorages extends StoragesComponent {
-    dataSourcesComp: DataSourcesComponent with PruningModeComponent =>
-
-    override val storages = new DefaultBlockchainStorages(pruningMode)
-
-    class DefaultBlockchainStorages(override val pruningMode: PruningMode) extends Storages with AppCaches {
-
-      override val blockHeadersStorage: BlockHeadersStorage = new BlockHeadersStorage(dataSources.blockHeadersDataSource)
-
-      override val blockBodiesStorage: BlockBodiesStorage = new BlockBodiesStorage(dataSources.blockBodiesDataSource)
-
-      override val blockNumberMappingStorage: BlockNumberMappingStorage = new IodbBlockNumberMappingStorage(dataSources.blockHeightsHashesDataSource)
-
-      override val receiptStorage: ReceiptStorage = new ReceiptStorage(dataSources.receiptsDataSource)
-
-      override val nodeStorage: NodeStorage = new NodeStorage(dataSources.mptDataSource)
-
-      override val cachedNodeStorage: CachedNodeStorage = new CachedNodeStorage(nodeStorage, caches.nodeCache)
-
-      override val fastSyncStateStorage: FastSyncStateStorage = new FastSyncStateStorage(dataSources.fastSyncStateDataSource)
-
-      override val evmCodeStorage: EvmCodeStorage = new EvmCodeStorage(dataSources.evmCodeDataSource)
-
-      override val totalDifficultyStorage: TotalDifficultyStorage =
-        new TotalDifficultyStorage(dataSources.totalDifficultyDataSource)
-
-      override val appStateStorage: AppStateStorage = new AppStateStorage(dataSources.appStateDataSource)
-
-      override val transactionMappingStorage: TransactionMappingStorage = new TransactionMappingStorage(dataSources.transactionMappingDataSource)
-
-      override val knownNodesStorage: KnownNodesStorage = new KnownNodesStorage(dataSources.knownNodesDataSource)
-
-      override val stateStorage: StateStorage =
-        StateStorage(
-          pruningMode,
-          nodeStorage,
-          cachedNodeStorage,
-          new LruCache[NodeHash, HeapEntry](Config.InMemoryPruningNodeCacheConfig, Some(CachedReferenceCountedStorage.saveOnlyNotificationHandler(nodeStorage)))
-        )
-    }
-  }
 }

src/main/scala/io/iohk/ethereum/db/components/SharedIodbDataSources.scala

@@ -182,15 +182,10 @@ object Config {
   object Db {
 
     private val dbConfig = config.getConfig("db")
-    private val iodbConfig = dbConfig.getConfig("iodb")
     private val rocksDbConfig = dbConfig.getConfig("rocksdb")
 
     val dataSource: String = dbConfig.getString("data-source")
 
-    object Iodb  {
-      val path: String = iodbConfig.getString("path")
-    }
-
     object RocksDb extends RocksDbConfig {
       override val createIfMissing: Boolean = rocksDbConfig.getBoolean("create-if-missing")
       override val paranoidChecks: Boolean = rocksDbConfig.getBoolean("paranoid-checks")

src/main/scala/io/iohk/ethereum/db/components/Storages.scala

@@ -15,7 +15,7 @@ snappy {
   # Path to the DB snapshot that contains all the blocks to be executed (and state for single-db)
   source-db-path = "path/to/source-db"
 
-  # Data source that should be used [rocksdb], iodb is not currently used
+  # Data source that should be used [rocksdb]
   data-source = "rocksdb"
 
   # Path to the DB where the state resulting from execution is saved (for single-db this is ignored)