This repository was archived by the owner on Aug 18, 2020. It is now read-only.
[DEVOPS-1153] Extend addWAddress to support newly-found accounts #3911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
reviewed
Nov 29, 2018
KtorZ
force-pushed
the
KtorZ/DEVOPS-1153/fix-old-data-layer-restoration-addWAddress
branch
from
1dbefd2 to
f0df3a3
Compare
erikd
approved these changes
Nov 29, 2018
The previous incarnation of `addWAddress` had a bug: in case of new accounts (like the ones we could find as part of a restoration) it wouldn't add the relevant address to the DB, because the old code was using a lens traversal with 'ix' which notoriously does nothing if the key (in this case the account index) was not there. This commit fixes it.
KtorZ
force-pushed
the
KtorZ/DEVOPS-1153/fix-old-data-layer-restoration-addWAddress
branch
from
f0df3a3 to
3a09150
Compare
deepfire
deleted the
KtorZ/DEVOPS-1153/fix-old-data-layer-restoration-addWAddress
branch
Contributor
|
Merged, because https://hydra.iohk.io/jobset/Cardano/cardano-sl-pr-3911 is green -- its the Github status machinery that failed us. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The restore process does not correctly restore the balance for additional accounts. (The flaw is that the "quick restore" only restores the balance for the accounts that were created already, and in the overall restore workflow only the first account gets created before the quick restore is kicked off).
See #3896
Linked issue
DEVOPS-1153
Type of change
Developer checklist
Testing checklist
I have added tests to cover my changes.QA Steps
Screenshots (if available)
How to merge
Send the message
bors r+to merge this PR. For more information, seedocs/how-to/bors.md.