Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

[release/1.3.1] [DEVOPS-398] Testnet genesis data #3265

Merged
merged 2 commits into from
Sep 26, 2018
Merged

[release/1.3.1] [DEVOPS-398] Testnet genesis data #3265

merged 2 commits into from
Sep 26, 2018

Conversation

@rvl
Copy link
Contributor

@rvl rvl commented Jul 18, 2018 •
edited
Loading

This is based on top off #3585, which should be merged first.

Description

  • Adds more address discrimination to configuration.yaml and rearranges the way the testnet sections inherit their config.
  • Updates the genesis data for testnet.

Linked issue

QA Steps

nix-build -A connectScripts.testnet.wallet -o connect-testnet.sh
./connect-testnet.sh

Screenshot

daedalus-testnet

@rvl rvl added git-flow hotfix This PR targets a release branch DO NOT MERGE release-1.3.1 labels Jul 18, 2018
@rvl rvl self-assigned this Jul 18, 2018
@rvl rvl requested a review from a team July 18, 2018 11:24
@rvl rvl mentioned this pull request Jul 20, 2018
Closed
@jmitchell
Copy link
Contributor

jmitchell commented Jul 23, 2018

Please do not merge because release/1.3.1 does not exist yet.

Until release/1.3.1 has been cut from develop should this PR target develop instead of release/1.3.0? Then the resulting Daedalus installers for input-output-hk/daedalus#1015 could more accurately reflect what release/1.3.1 will eventually be.

@rvl
Copy link
Contributor Author

rvl commented Jul 23, 2018

I understood that the hotfix release/1.3.1 will not be cut from develop, but rather from the v1.3.0 tag, which will be on either the master or release/1.3.0 branch.

The DEVOPS-398 changes on this branch that I cherry-picked from develop did not all apply cleanly to release/1.3.0.

@jmitchell
Copy link
Contributor

jmitchell commented Jul 23, 2018

I understood that the hotfix release/1.3.1 will not be cut from develop, but rather from the v1.3.0 tag

Yes, my mistake.

@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch from aa850e0 to 5a22e15 Compare July 26, 2018 14:51
@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch from 6245e4e to f4c86cc Compare August 3, 2018 11:42
@rvl
Copy link
Contributor Author

rvl commented Aug 3, 2018

Rebased on latest release/1.3.0 and resolved merge conflicts in launch scripts/demo cluster.

@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch from f4c86cc to e760af7 Compare August 9, 2018 13:49
@rvl rvl changed the base branch from release/1.3.0 to release/1.3.1 August 9, 2018 13:50
@rvl rvl added wip and removed DO NOT MERGE labels Aug 9, 2018
@rvl rvl changed the title [DEVOPS-398] Testnet genesis for release/1.3.1 branch WIP [DEVOPS-398] Testnet genesis for release/1.3.1 branch Aug 9, 2018
@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch from e760af7 to fbc34aa Compare August 24, 2018 08:36
@rvl rvl mentioned this pull request Aug 24, 2018
Merged
@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch 2 times, most recently from bbe770c to 863563c Compare September 10, 2018 07:21
@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch from 863563c to ff98839 Compare September 13, 2018 04:59
@rvl rvl changed the title WIP [DEVOPS-398] Testnet genesis for release/1.3.1 branch WIP [release/1.3.1] [DEVOPS-398] Testnet genesis data Sep 13, 2018
@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch 5 times, most recently from df6c603 to 0c61eb8 Compare September 19, 2018 00:25
mhuesch
mhuesch reviewed Sep 19, 2018
View reviewed changes
@disassembler disassembler force-pushed the devops-398-testnet-genesis-1.3.1 branch from 7af6671 to d57d8c2 Compare September 19, 2018 02:10
@rvl
Copy link
Contributor Author

rvl commented Sep 19, 2018

On this branch I have tested:

nix-build -A connectScripts.testnet.wallet -o connect-testnet.sh && ./connect-testnet.sh

This sync successfully and proves that the validation errors I was seeing before is because I hadn't merged the right branch into my test branch.

nix-build -A connectScripts.mainnet.wallet -o connect-mainnet.sh && ./connect-mainnet.sh

This fails with:

[node:ERROR:ThreadId 5] [2018-09-19 02:22:01.02 UTC] logException: GenesisHashMismatch "AbstractHash 4832ba94116f22e49f0da1ff5e305ee7fe1a736fecf2fdbe6b8db31039148ae9" "AbstractHash 5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb"
cardano-node: GenesisHashMismatch "AbstractHash 4832ba94116f22e49f0da1ff5e305ee7fe1a736fecf2fdbe6b8db31039148ae9" "AbstractHash 5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb"

which means there is probably something wrong with the mainnet_full configuration in #3585 which needs to be fixed.

(If wondering how to debug this, cat connect-mainnet.sh then adjust the cardano-node command line to use your chosen binary and configuration file.)

@disassembler
Copy link
Contributor

disassembler commented Sep 19, 2018

I'll try running the wallet on mainnet and staging after hydra builds everything. Unless you already have CO-354 in your branch (as of a few minutes ago) good chance that last commit resolves the issues you're having.

@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch 4 times, most recently from c8ceb81 to fec434f Compare September 26, 2018 01:47
@rvl rvl changed the title WIP [release/1.3.1] [DEVOPS-398] Testnet genesis data [release/1.3.1] [DEVOPS-398] Testnet genesis data Sep 26, 2018
@rvl rvl removed the wip label Sep 26, 2018
mhuesch
mhuesch reviewed Sep 26, 2018
View reviewed changes
Copy link
Contributor

@mhuesch mhuesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the last 2 commits on this (c69ba4e & fec434f), and they look reasonable to me. However I think @intricate should give the final say since he masterminded the new configuration setup.

rvl added 2 commits September 26, 2018 14:05
@rvl
[DEVOPS-398] configuration.yaml: rearrange testnet sections
f8dbac3 
 - mainnet_base - in the genesis spec protocolMagic requiresNetworkMagic
   is omitted and therefore gets the default setting NMMustBeJust.

 - mainnet_full - genesis data remains the same.

 - testnet_launch - do not inherit protocolConstants from
   mainnet_base_spec. Copy across these parameters. In this genesis
   spec, requiresNetworkMagic is explicitly stated as NMMustBeJust,
   even though that would be the default value.

 - testnet_full - new genesis data will be generated from
   testnet_launch and updated after starting the blockchain.

 - devnet, other "leaf configurations" have requiresNetworkMagic:
   NMMustBeNothing which overrides the mainnet_base setting. This is so
   that the address format of the devnets matches mainnet_full.

For testnet, the YAML "inheritance" direction is now:

  mainnet_base -> testnet_launch -> testnet_full

This ensures that testnet_full gets all the genesis spec attributes --
requiresNetworkMagic in particular.
@rvl
[DEVOPS-398] configuration.yaml: new genesis data for testnet_full
3c7e805 
New genesis data created with requiresNetworkMagic: NMMustBeJust.
@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch from fec434f to 2e0d112 Compare September 26, 2018 05:35
@rvl
Copy link
Contributor Author

rvl commented Sep 26, 2018

Thanks. Now that #3585 is merged, I have rebased on release/1.3.1 and also generated new genesis data from exactly this configuration.yaml (not one which was slightly different but effectively the same).

@rvl rvl force-pushed the devops-398-testnet-genesis-1.3.1 branch from 2e0d112 to 3c7e805 Compare September 26, 2018 06:35
@rvl rvl merged commit 061980e into release/1.3.1 Sep 26, 2018
@rvl rvl deleted the devops-398-testnet-genesis-1.3.1 branch September 26, 2018 15:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@erikd erikd Awaiting requested review from erikd erikd is a code owner

@iohk-devops iohk-devops Awaiting requested review from iohk-devops

@adinapoli-iohk adinapoli-iohk Awaiting requested review from adinapoli-iohk

@akegalj akegalj Awaiting requested review from akegalj

@avieth avieth Awaiting requested review from avieth

@dcoutts dcoutts Awaiting requested review from dcoutts

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@parsonsmatt parsonsmatt Awaiting requested review from parsonsmatt

@vincenthz vincenthz Awaiting requested review from vincenthz

3 more reviewers

@disassembler disassembler disassembler left review comments

@mhuesch mhuesch mhuesch left review comments

@intricate intricate intricate approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@rvl rvl

Labels

git-flow hotfix This PR targets a release branch release-1.3.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rvl @jmitchell @disassembler @mhuesch @intricate