[CO-354] Add tests for mainnet/staging ProtocolMagic

We want to be sure that mainnet/staging both have `NMMustBeNothing`
as the `requiresNetworkMagic` field of their `ProtocolMagic` value,
which is read from config.

We add a simple test which can be run on the `lib/configuration.yaml`
file and check multiple YAML keys for valid `RequiresNetworkMagic`s.

We also fix the JSON file, which caused the test to fail because it
did not have an explicit `requiresNetworkMagic: NMMustBeNothing` in
it.

(cherry picked from commit 3166d5b)

Author: Michael Hueschen

lib/cardano-sl.cabal

@@ -279,6 +279,7 @@ test-suite cardano-test
 
                        -- Everything else
                        Test.Pos.Cbor.CborSpec
+                       Test.Pos.ConfigurationSpec
                        Test.Pos.ConstantsSpec
                        Test.Pos.CryptoSpec
                        Test.Pos.Diffusion.BlockSpec
@@ -331,6 +332,7 @@ test-suite cardano-test
                      , generic-arbitrary
                      , hspec
                      , lens
+                     , log-warper
                      , mtl
                      , network-transport
                      , network-transport-inmemory

lib/configuration.yaml

@@ -14777,7 +14777,7 @@ mainnet_full: &mainnet_full
       <<: *mainnet_base_genesis
       src:
         file: mainnet-genesis.json
-        hash: 5f20df933584822601f9e3f8c024eb5eb252fe8cefb24d1317dc3d432e940ebb
+        hash: 204beb98e6589cdc5cbc98b99a62fdc877dd01c35c66f6d4f85a576c949cc018
       spec:
         <<: *mainnet_base_spec
         protocolConstants:

lib/mainnet-genesis.json

@@ -14532,7 +14532,10 @@
     "ftsSeed": "76617361206f7061736120736b6f766f726f64612047677572646120626f726f64612070726f766f6461",
     "protocolConsts": {
         "k": 2160,
-        "protocolMagic": 764824073,
+        "protocolMagic": {
+            "pm": 764824073,
+            "requiresNetworkMagic": "NMMustBeNothing"
+        },
         "vssMaxTTL": 6,
         "vssMinTTL": 2
     },

lib/test/Test/Pos/ConfigurationSpec.hs

@@ -0,0 +1,49 @@
+{-# OPTIONS_GHC -fno-warn-orphans #-}
+
+-- | This module tests configuration.
+
+module Test.Pos.ConfigurationSpec
+       ( spec
+       ) where
+
+import           Universum
+
+import           System.Wlog (HasLoggerName (..), LoggerName (..))
+
+import           Mockable.Production (Production (..))
+import           Pos.Core.Slotting (getCurrentTimestamp)
+import           Pos.Crypto (ProtocolMagic (..), RequiresNetworkMagic (..))
+import           Pos.Infra.Ntp.Configuration (NtpConfiguration)
+import           Pos.Launcher.Configuration (ConfigurationOptions (..), withConfigurations)
+
+import           Test.Hspec (Spec, describe, it, runIO, shouldBe)
+
+instance HasLoggerName IO where
+    askLoggerName = pure $ LoggerName "ConfigurationSpec"
+    modifyLoggerName _ x = x
+
+configFilePath :: FilePath
+configFilePath = "configuration.yaml"
+
+checkYamlSection :: Text -> Spec
+checkYamlSection key = describe ("key: " ++ show key) $ do
+    startTime <- runIO (runProduction getCurrentTimestamp)
+    let opts = ConfigurationOptions configFilePath key (Just startTime) Nothing
+    rnm <- runIO (withConfigurations Nothing opts getRNM)
+    it "should be NMMustBeNothing" $
+        rnm `shouldBe` NMMustBeNothing
+
+getRNM :: NtpConfiguration -> ProtocolMagic -> IO RequiresNetworkMagic
+getRNM _ pm = pure (getRequiresNetworkMagic pm)
+
+spec :: Spec
+spec = mapM_ checkYamlSection [
+    "mainnet_full" -- mainnet core/relay nodes and exchange wallets
+    "mainnet_dryrun_full" -- staging core/relay nodes and exchange wallets
+    "mainnet_wallet_win64" -- mainnet wallets (daedalus)
+    "mainnet_wallet_mac64"
+    "mainnet_wallet_linux64"
+    "mainnet_dryrun_wallet_win64" -- staging wallets (daedalus)
+    "mainnet_dryrun_wallet_mac64"
+    "mainnet_dryrun_wallet_linux64"
+  ]

pkgs/default.nix

@@ -14850,6 +14850,7 @@ formatting
 generic-arbitrary
 hspec
 lens
+log-warper
 mtl
 network-transport
 network-transport-inmemory