Skip to content

Commit 02d0106

Browse files
fix(input-stepper): make decrement and increment functions protected instead of private (#2568)
1 parent b80c6f4 commit 02d0106

File tree

2 files changed

+15
-10
lines changed

2 files changed

+15
-10
lines changed

.changeset/perfect-suits-dream.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@lion/ui': patch
3+
---
4+
5+
[input-stepper] make decrement and increment functions protected instead of private

packages/ui/components/input-stepper/src/LionInputStepper.js

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,8 @@ export class LionInputStepper extends LocalizeMixin(LionInput) {
9494
step: this.step,
9595
};
9696

97-
this.__increment = this.__increment.bind(this);
98-
this.__decrement = this.__decrement.bind(this);
97+
this._increment = this._increment.bind(this);
98+
this._decrement = this._decrement.bind(this);
9999
this._onEnterButton = this._onEnterButton.bind(this);
100100
this._onLeaveButton = this._onLeaveButton.bind(this);
101101
}
@@ -192,11 +192,11 @@ export class LionInputStepper extends LocalizeMixin(LionInput) {
192192
*/
193193
__keyDownHandler(ev) {
194194
if (ev.key === 'ArrowUp') {
195-
this.__increment();
195+
this._increment();
196196
}
197197

198198
if (ev.key === 'ArrowDown') {
199-
this.__decrement();
199+
this._decrement();
200200
}
201201
}
202202

@@ -262,9 +262,9 @@ export class LionInputStepper extends LocalizeMixin(LionInput) {
262262

263263
/**
264264
* Increment the value based on given step or default step value is 1
265-
* @private
265+
* @protected
266266
*/
267-
__increment() {
267+
_increment() {
268268
const { step, min, max } = this.values;
269269
const stepMin = min !== Infinity ? min : 0;
270270

@@ -284,9 +284,9 @@ export class LionInputStepper extends LocalizeMixin(LionInput) {
284284

285285
/**
286286
* Decrement the value based on given step or default step value is 1
287-
* @private
287+
* @protected
288288
*/
289-
__decrement() {
289+
_decrement() {
290290
const { step, max, min } = this.values;
291291
const stepMin = min !== Infinity ? min : 0;
292292

@@ -379,7 +379,7 @@ export class LionInputStepper extends LocalizeMixin(LionInput) {
379379
return html`
380380
<button
381381
?disabled=${this.disabled || this.readOnly}
382-
@click=${this.__decrement}
382+
@click=${this._decrement}
383383
@focus=${this._onEnterButton}
384384
@blur=${this._onLeaveButton}
385385
type="button"
@@ -399,7 +399,7 @@ export class LionInputStepper extends LocalizeMixin(LionInput) {
399399
return html`
400400
<button
401401
?disabled=${this.disabled || this.readOnly}
402-
@click=${this.__increment}
402+
@click=${this._increment}
403403
@focus=${this._onEnterButton}
404404
@blur=${this._onLeaveButton}
405405
type="button"

0 commit comments

Comments
 (0)