Merge pull request #2586 from fintelia/remove-pcx

Remove PCX code

Author: 197g

src/codecs/pcx.rs

@@ -207,8 +207,6 @@ impl<'a, R: 'a + BufRead + Seek> ImageReader<R> {
             ImageFormat::Farbfeld => Box::new(farbfeld::FarbfeldDecoder::new(reader)?),
             #[cfg(feature = "qoi")]
             ImageFormat::Qoi => Box::new(qoi::QoiDecoder::new(reader)?),
-            #[cfg(feature = "pcx")]
-            ImageFormat::Pcx => Box::new(pcx::PCXDecoder::new(reader)?),
             format => {
                 return Err(ImageError::Unsupported(
                     ImageFormatHint::Exact(format).into(),

src/io/image_reader_type.rs

@@ -118,14 +118,6 @@
 #![deny(missing_copy_implementations)]
 #![cfg_attr(all(test, feature = "benchmarks"), feature(test))]
 #![cfg_attr(docsrs, feature(doc_auto_cfg))]
-// We've temporarily disabled PCX support for 0.25.5 release
-// by removing the corresponding feature.
-// We want to ship bug fixes without committing to PCX support.
-//
-// Cargo shows warnings about code depending on a nonexistent feature
-// even to people using the crate as a dependency,
-// so we have to suppress those warnings.
-#![allow(unexpected_cfgs)]
 
 #[cfg(all(test, feature = "benchmarks"))]
 extern crate test;
@@ -266,8 +258,6 @@ pub mod codecs {
     pub mod jpeg;
     #[cfg(feature = "exr")]
     pub mod openexr;
-    #[cfg(feature = "pcx")]
-    pub mod pcx;
     #[cfg(feature = "png")]
     pub mod png;
     #[cfg(feature = "pnm")]

src/lib.rs

@@ -18,7 +18,7 @@ where
 {
     let base: PathBuf = BASE_PATH.iter().collect();
     let decoders = &[
-        "tga", "tiff", "png", "gif", "bmp", "ico", "hdr", "pbm", "webp", "pcx",
+        "tga", "tiff", "png", "gif", "bmp", "ico", "hdr", "pbm", "webp",
     ];
     for decoder in decoders {
         let mut path = base.clone();

tests/images/pcx/images/24bit.pcx

@@ -16,7 +16,7 @@ where
 {
     let base: PathBuf = BASE_PATH.iter().collect();
     let decoders = &[
-        "tga", "tiff", "png", "gif", "bmp", "ico", "jpg", "hdr", "farbfeld", "exr", "pcx",
+        "tga", "tiff", "png", "gif", "bmp", "ico", "jpg", "hdr", "farbfeld", "exr",
     ];
     for decoder in decoders {
         let mut path = base.clone();
@@ -100,8 +100,3 @@ fn truncate_farbfeld() {
 fn truncate_exr() {
     truncate_images("exr");
 }
-
-#[test]
-fn truncate_pcx() {
-    truncate_images("pcx");
-}