refactor: better check for arg type in Retry action (microsoft#232645)

Author: joyceerhl

src/vs/workbench/contrib/chat/browser/actions/chatTitleActions.ts

@@ -28,7 +28,7 @@ import { CellEditType, CellKind, NOTEBOOK_EDITOR_ID } from '../../../notebook/co
 import { NOTEBOOK_IS_ACTIVE_EDITOR } from '../../../notebook/common/notebookContextKeys.js';
 import { ChatAgentLocation, IChatAgentService } from '../../common/chatAgents.js';
 import { ChatContextKeys } from '../../common/chatContextKeys.js';
-import { applyingChatEditsFailedContextKey, IChatEditingService, WorkingSetEntryState } from '../../common/chatEditingService.js';
+import { applyingChatEditsFailedContextKey, IChatEditingService, isChatEditingActionContext, WorkingSetEntryState } from '../../common/chatEditingService.js';
 import { IParsedChatRequest } from '../../common/chatParserTypes.js';
 import { ChatAgentVoteDirection, ChatAgentVoteDownReason, IChatProgress, IChatService } from '../../common/chatService.js';
 import { isRequestVM, isResponseVM } from '../../common/chatViewModel.js';
@@ -211,7 +211,8 @@ export function registerChatTitleActions() {
 			const chatWidgetService = accessor.get(IChatWidgetService);
 
 			let item = args[0];
-			if (typeof item === 'object' && !!item && 'sessionId' in item) {
+			if (isChatEditingActionContext(item)) {
+				// Resolve chat editing action context to the last response VM
 				item = chatWidgetService.getWidgetBySessionId(item.sessionId)?.viewModel?.getItems().at(-1);
 			}
 			if (!isResponseVM(item)) {

src/vs/workbench/contrib/chat/common/chatEditingService.ts

@@ -116,3 +116,12 @@ export const enum ChatEditKind {
 	Created,
 	Modified,
 }
+
+export interface IChatEditingActionContext {
+	// The chat session ID that this editing session is associated with
+	sessionId: string;
+}
+
+export function isChatEditingActionContext(thing: unknown): thing is IChatEditingActionContext {
+	return typeof thing === 'object' && !!thing && 'sessionId' in thing;
+}