Implemented changes from the code review

Author: axunonb

Ical.Net.Tests/RecurrenceTests.cs

@@ -30,6 +30,10 @@ int eventIndex
         )
         {
             var evt = cal.Events.Skip(eventIndex).First();
+            var rule = evt.RecurrenceRules.FirstOrDefault();
+#pragma warning disable 0618
+            if (rule != null) rule.RestrictionType = RecurrenceRestrictionType.NoRestriction;
+#pragma warning restore 0618
             fromDate.AssociatedObject = cal;
             toDate.AssociatedObject = cal;
 
@@ -2767,6 +2771,9 @@ public void Evaluate1(string freq, int secsPerInterval, bool hasTime)
             // This case (DTSTART of type DATE and FREQ=MINUTELY) is undefined in RFC 5545.
             // ical.net handles the case by pretending DTSTART has the time set to midnight.
             evt.RecurrenceRules.Add(new RecurrencePattern($"FREQ={freq};INTERVAL=10;COUNT=5"));
+#pragma warning disable 0618
+            evt.RecurrenceRules[0].RestrictionType = RecurrenceRestrictionType.NoRestriction;
+#pragma warning restore 0618
 
             var occurrences = evt.GetOccurrences(CalDateTime.Today.AddDays(-1), CalDateTime.Today.AddDays(100))
                 .OrderBy(x => x)
@@ -2791,6 +2798,9 @@ public void RecurrencePattern1()
             // NOTE: evaluators are not generally meant to be used directly like this.
             // However, this does make a good test to ensure they behave as they should.
             var pattern = new RecurrencePattern("FREQ=SECONDLY;INTERVAL=10");
+#pragma warning disable 0618
+            pattern.RestrictionType = RecurrenceRestrictionType.NoRestriction;
+#pragma warning restore 0618
 
             var us = new CultureInfo("en-US");
 

Ical.Net/DataTypes/RecurrencePattern.cs

@@ -15,9 +15,10 @@ namespace Ical.Net.DataTypes
     public class RecurrencePattern : EncodableDataType
     {
         private int _interval = int.MinValue;
+#pragma warning disable 0618
         private RecurrenceRestrictionType? _restrictionType;
         private RecurrenceEvaluationModeType? _evaluationMode;
-
+#pragma warning restore 0618
         public FrequencyType Frequency { get; set; }
 
         private DateTime _until = DateTime.MinValue;
@@ -84,6 +85,7 @@ public int Interval
 
         public DayOfWeek FirstDayOfWeek { get; set; } = DayOfWeek.Monday;
 
+#pragma warning disable 0618
         /// <summary>
         /// The type of restriction to apply to the evaluation of this recurrence pattern.
         /// Returns <see cref="RecurrenceRestrictionType.NoRestriction"/> if not set.
@@ -98,7 +100,7 @@ public RecurrenceRestrictionType RestrictionType
                 {
                     return _restrictionType.Value;
                 }
-                return RecurrenceRestrictionType.NoRestriction;
+                return Calendar?.RecurrenceRestriction ?? RecurrenceRestrictionType.Default;
             }
             set => _restrictionType = value;
         }
@@ -117,6 +119,7 @@ public RecurrenceEvaluationModeType EvaluationMode
             }
             set => _evaluationMode = value;
         }
+#pragma warning restore 0618
 
         public RecurrencePattern()
         {
@@ -148,8 +151,10 @@ public override string ToString()
         }
 
         protected bool Equals(RecurrencePattern other) => (Interval == other.Interval)
+#pragma warning disable 0618
             && RestrictionType == other.RestrictionType
             && EvaluationMode == other.EvaluationMode
+#pragma warning restore 0618
             && Frequency == other.Frequency
             && Until.Equals(other.Until)
             && Count == other.Count
@@ -176,8 +181,10 @@ public override int GetHashCode()
             unchecked
             {
                 var hashCode = Interval.GetHashCode();
+#pragma warning disable 0618
                 hashCode = (hashCode * 397) ^ RestrictionType.GetHashCode();
                 hashCode = (hashCode * 397) ^ EvaluationMode.GetHashCode();
+#pragma warning restore 0618
                 hashCode = (hashCode * 397) ^ (int)Frequency;
                 hashCode = (hashCode * 397) ^ Until.GetHashCode();
                 hashCode = (hashCode * 397) ^ Count;
@@ -218,8 +225,10 @@ public override void CopyFrom(ICopyable obj)
             ByMonth = new List<int>(r.ByMonth);
             BySetPosition = new List<int>(r.BySetPosition);
             FirstDayOfWeek = r.FirstDayOfWeek;
+#pragma warning disable 0618
             RestrictionType = r.RestrictionType;
             EvaluationMode = r.EvaluationMode;
+#pragma warning restore 0618
         }
 
         private static bool CollectionEquals<T>(IEnumerable<T> c1, IEnumerable<T> c2) => c1.SequenceEqual(c2);

Ical.Net/Evaluation/RecurrencePatternEvaluator.cs

@@ -135,7 +135,7 @@ private RecurrencePattern ProcessRecurrencePattern(IDateTime referenceDate)
 
             return r;
         }
-
+#pragma warning disable 0618
         private void EnforceEvaluationRestrictions(RecurrencePattern pattern)
         {
             RecurrenceEvaluationModeType? evaluationMode = pattern.EvaluationMode;
@@ -230,7 +230,7 @@ private void EnforceEvaluationRestrictions(RecurrencePattern pattern)
                 }
             }
         }
-
+#pragma warning 0618 restore
         /// <summary>
         /// Returns a list of start dates in the specified period represented by this recurrence pattern.
         /// This method includes a base date argument, which indicates the start of the first occurrence of this recurrence.