Skip to content

Commit 83430bc

Browse files
committed
(feat) adapt market data router to use connector name instead of connector
1 parent 3f62305 commit 83430bc

File tree

3 files changed

+31
-31
lines changed

3 files changed

+31
-31
lines changed

examples/example_2_open_and_close_position.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ async def open_and_close_a_position(hbot_client: HummingbotAPIClient, interval:
2626

2727

2828
# 3: Convert 100 USDT to ERA
29-
price = await hbot_client.market_data.get_prices(connector="binance_perpetual", trading_pairs="ERA-USDT")
29+
price = await hbot_client.market_data.get_prices(connector_name="binance_perpetual", trading_pairs="ERA-USDT")
3030
amount_in_era = 100 / price["prices"]["ERA-USDT"]
3131

3232
# 4: Open a long position on ERA-USDT on Binance perpetual with 100 USDT

examples/example_4_quoting_on_different_venues.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ async def quoting_on_multiple_exchanges(hbot_client: HummingbotAPIClient, bot: B
2121
trading_pair = "WLD-USDT"
2222
quote_volume = 200000.0
2323
tasks = [hbot_client.market_data.get_price_for_quote_volume(
24-
connector=connector, trading_pair=trading_pair, quote_volume=quote_volume, is_buy=True) for connector in connectors_to_quote]
24+
connector_name=connector, trading_pair=trading_pair, quote_volume=quote_volume, is_buy=True) for connector in connectors_to_quote]
2525
prices = await asyncio.gather(*tasks)
2626
message = f"📈 *Quoting on Multiple Exchanges*\n\n"
2727
for connector, price in zip(connectors_to_quote, prices):

hummingbot_api_client/routers/market_data.py

Lines changed: 29 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ async def get_candles(
3535

3636
async def get_historical_candles(
3737
self,
38-
connector: str,
38+
connector_name: str,
3939
trading_pair: str,
4040
interval: str = "1m",
4141
start_time: Optional[int] = None,
@@ -45,7 +45,7 @@ async def get_historical_candles(
4545
Get historical candles data for a specific trading pair.
4646
4747
Args:
48-
connector: Exchange connector name (e.g., "binance", "binance_perpetual")
48+
connector_name: Exchange connector name (e.g., "binance", "binance_perpetual")
4949
trading_pair: Trading pair (e.g., "BTC-USDT")
5050
interval: Candle interval (e.g., "1m", "5m", "1h", "1d")
5151
start_time: Start timestamp (Unix timestamp in seconds)
@@ -59,7 +59,7 @@ async def get_historical_candles(
5959
get_candles_last_days() or higher intervals (5m, 1h) to avoid timeouts.
6060
"""
6161
config = {
62-
"connector_name": connector,
62+
"connector_name": connector_name,
6363
"trading_pair": trading_pair,
6464
"interval": interval
6565
}
@@ -72,7 +72,7 @@ async def get_historical_candles(
7272

7373
async def get_candles_last_days(
7474
self,
75-
connector: str,
75+
connector_name: str,
7676
trading_pair: str,
7777
days: int,
7878
interval: str = "1h"
@@ -81,7 +81,7 @@ async def get_candles_last_days(
8181
Get candles for the last N days.
8282
8383
Args:
84-
connector: Exchange connector name (e.g., "binance", "binance_perpetual")
84+
connector_name: Exchange connector name (e.g., "binance", "binance_perpetual")
8585
trading_pair: Trading pair (e.g., "BTC-USDT")
8686
days: Number of days to look back (e.g., 1, 7, 30)
8787
interval: Candle interval (e.g., "1m", "5m", "1h", "1d")
@@ -106,7 +106,7 @@ async def get_candles_last_days(
106106
start_time = end_time - (days * 24 * 60 * 60) # days * seconds_per_day
107107

108108
return await self.get_historical_candles(
109-
connector=connector,
109+
connector_name=connector_name,
110110
trading_pair=trading_pair,
111111
interval=interval,
112112
start_time=start_time,
@@ -133,7 +133,7 @@ async def get_market_data_settings(self) -> Dict[str, Any]:
133133
# Enhanced Market Data Operations
134134
async def get_prices(
135135
self,
136-
connector: str,
136+
connector_name: str,
137137
trading_pairs: Union[str, List[str]]
138138
) -> Dict[str, Any]:
139139
"""
@@ -154,17 +154,17 @@ async def get_prices(
154154
trading_pairs = [trading_pairs]
155155

156156
price_request = {
157-
"connector_name": connector,
157+
"connector_name": connector_name,
158158
"trading_pairs": trading_pairs
159159
}
160160
return await self._post("/market-data/prices", json=price_request)
161161

162-
async def get_funding_info(self, connector: str, trading_pair: str) -> Dict[str, Any]:
162+
async def get_funding_info(self, connector_name: str, trading_pair: str) -> Dict[str, Any]:
163163
"""
164164
Get funding information for a perpetual trading pair.
165165
166166
Args:
167-
connector: Perpetual exchange connector name (e.g., "binance_perpetual")
167+
connector_name: Perpetual exchange connector name (e.g., "binance_perpetual")
168168
trading_pair: Trading pair (e.g., "BTC-USDT")
169169
170170
Returns:
@@ -174,22 +174,22 @@ async def get_funding_info(self, connector: str, trading_pair: str) -> Dict[str,
174174
funding = await client.market_data.get_funding_info("binance_perpetual", "BTC-USDT")
175175
"""
176176
funding_request = {
177-
"connector_name": connector,
177+
"connector_name": connector_name,
178178
"trading_pair": trading_pair
179179
}
180180
return await self._post("/market-data/funding-info", json=funding_request)
181181

182182
async def get_order_book(
183183
self,
184-
connector: str,
184+
connector_name: str,
185185
trading_pair: str,
186186
depth: int = 10
187187
) -> Dict[str, Any]:
188188
"""
189189
Get order book snapshot with specified depth.
190190
191191
Args:
192-
connector: Exchange connector name (e.g., "binance", "binance_perpetual")
192+
connector_name: Exchange connector name (e.g., "binance", "binance_perpetual")
193193
trading_pair: Trading pair (e.g., "BTC-USDT")
194194
depth: Number of price levels to return (1-100)
195195
@@ -200,7 +200,7 @@ async def get_order_book(
200200
order_book = await client.market_data.get_order_book("binance", "BTC-USDT", depth=20)
201201
"""
202202
order_book_request = {
203-
"connector_name": connector,
203+
"connector_name": connector_name,
204204
"trading_pair": trading_pair,
205205
"depth": depth
206206
}
@@ -209,7 +209,7 @@ async def get_order_book(
209209
# Order Book Query Operations
210210
async def get_price_for_volume(
211211
self,
212-
connector: str,
212+
connector_name: str,
213213
trading_pair: str,
214214
volume: float,
215215
is_buy: bool
@@ -218,7 +218,7 @@ async def get_price_for_volume(
218218
Get the price required to fill a specific volume on the order book.
219219
220220
Args:
221-
connector: Exchange connector name (e.g., "binance", "binance_perpetual")
221+
connector_name: Exchange connector name (e.g., "binance", "binance_perpetual")
222222
trading_pair: Trading pair (e.g., "BTC-USDT")
223223
volume: Volume to fill (in base asset)
224224
is_buy: True for buy side, False for sell side
@@ -231,7 +231,7 @@ async def get_price_for_volume(
231231
result = await client.market_data.get_price_for_volume("binance", "BTC-USDT", 1.0, True)
232232
"""
233233
request = {
234-
"connector_name": connector,
234+
"connector_name": connector_name,
235235
"trading_pair": trading_pair,
236236
"volume": volume,
237237
"is_buy": is_buy
@@ -240,7 +240,7 @@ async def get_price_for_volume(
240240

241241
async def get_volume_for_price(
242242
self,
243-
connector: str,
243+
connector_name: str,
244244
trading_pair: str,
245245
price: float,
246246
is_buy: bool
@@ -249,7 +249,7 @@ async def get_volume_for_price(
249249
Get the volume available at a specific price level on the order book.
250250
251251
Args:
252-
connector: Exchange connector name (e.g., "binance", "binance_perpetual")
252+
connector_name: Exchange connector name (e.g., "binance", "binance_perpetual")
253253
trading_pair: Trading pair (e.g., "BTC-USDT")
254254
price: Price level to query
255255
is_buy: True for buy side, False for sell side
@@ -262,7 +262,7 @@ async def get_volume_for_price(
262262
result = await client.market_data.get_volume_for_price("binance", "BTC-USDT", 50000.0, True)
263263
"""
264264
request = {
265-
"connector_name": connector,
265+
"connector_name": connector_name,
266266
"trading_pair": trading_pair,
267267
"price": price,
268268
"is_buy": is_buy
@@ -271,7 +271,7 @@ async def get_volume_for_price(
271271

272272
async def get_price_for_quote_volume(
273273
self,
274-
connector: str,
274+
connector_name: str,
275275
trading_pair: str,
276276
quote_volume: float,
277277
is_buy: bool
@@ -280,7 +280,7 @@ async def get_price_for_quote_volume(
280280
Get the price required to fill a specific quote volume on the order book.
281281
282282
Args:
283-
connector: Exchange connector name (e.g., "binance", "binance_perpetual")
283+
connector_name: Exchange connector name (e.g., "binance", "binance_perpetual")
284284
trading_pair: Trading pair (e.g., "BTC-USDT")
285285
quote_volume: Quote volume to fill (in quote asset, e.g., USDT)
286286
is_buy: True for buy side, False for sell side
@@ -293,7 +293,7 @@ async def get_price_for_quote_volume(
293293
result = await client.market_data.get_price_for_quote_volume("binance", "BTC-USDT", 10000.0, True)
294294
"""
295295
request = {
296-
"connector_name": connector,
296+
"connector_name": connector_name,
297297
"trading_pair": trading_pair,
298298
"quote_volume": quote_volume,
299299
"is_buy": is_buy
@@ -302,7 +302,7 @@ async def get_price_for_quote_volume(
302302

303303
async def get_quote_volume_for_price(
304304
self,
305-
connector: str,
305+
connector_name: str,
306306
trading_pair: str,
307307
price: float,
308308
is_buy: bool
@@ -311,7 +311,7 @@ async def get_quote_volume_for_price(
311311
Get the quote volume available at a specific price level on the order book.
312312
313313
Args:
314-
connector: Exchange connector name (e.g., "binance", "binance_perpetual")
314+
connector_name: Exchange connector name (e.g., "binance", "binance_perpetual")
315315
trading_pair: Trading pair (e.g., "BTC-USDT")
316316
price: Price level to query
317317
is_buy: True for buy side, False for sell side
@@ -324,7 +324,7 @@ async def get_quote_volume_for_price(
324324
result = await client.market_data.get_quote_volume_for_price("binance", "BTC-USDT", 50000.0, True)
325325
"""
326326
request = {
327-
"connector_name": connector,
327+
"connector_name": connector_name,
328328
"trading_pair": trading_pair,
329329
"price": price,
330330
"is_buy": is_buy
@@ -333,7 +333,7 @@ async def get_quote_volume_for_price(
333333

334334
async def get_vwap_for_volume(
335335
self,
336-
connector: str,
336+
connector_name: str,
337337
trading_pair: str,
338338
volume: float,
339339
is_buy: bool
@@ -342,7 +342,7 @@ async def get_vwap_for_volume(
342342
Get the VWAP (Volume Weighted Average Price) for a specific volume on the order book.
343343
344344
Args:
345-
connector: Exchange connector name (e.g., "binance", "binance_perpetual")
345+
connector_name: Exchange connector name (e.g., "binance", "binance_perpetual")
346346
trading_pair: Trading pair (e.g., "BTC-USDT")
347347
volume: Volume to calculate VWAP for (in base asset)
348348
is_buy: True for buy side, False for sell side
@@ -355,7 +355,7 @@ async def get_vwap_for_volume(
355355
result = await client.market_data.get_vwap_for_volume("binance", "BTC-USDT", 1.0, True)
356356
"""
357357
request = {
358-
"connector_name": connector,
358+
"connector_name": connector_name,
359359
"trading_pair": trading_pair,
360360
"volume": volume,
361361
"is_buy": is_buy

0 commit comments

Comments
 (0)