Skip to content

[bnb] Fix non passing trainer tests #18584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2022
Merged

[bnb] Fix non passing trainer tests #18584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/trainer/test_trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2398,7 +2398,7 @@ def test_bnb_adam8bit_no_bnb(self):

# Pretend that bnb does not exist, even if installed. By setting bnb to None, importing
# bnb will fail even if bnb is installed.
with patch.dict("sys.modules", {"bnb.optim": None}):
with patch.dict("sys.modules", {"bitsandbytes.optim": None}):
Copy link
Collaborator

@ydshieh ydshieh Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So now bitsandbytes is invisible with this change?

Copy link
Contributor Author

@younesbelkada younesbelkada Aug 11, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes inside this context manager bistandbytes should be invisible. Before it tried to overwrite the bnb module but it didn't existed (you can also check the lines above)

Copy link
Contributor

@stas00 stas00 Aug 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally wasn't even sure why we needed the mock test when we have the actual library to test with. But since the effort was made to write it, I said why not.

with self.assertRaises(ValueError):
Trainer.get_optimizer_cls_and_kwargs(args)

Expand Down