Skip to content

Commit 95ccba3

Browse files
authored
Bump sccache to 0.10.0 (#3179)
* Ensure that `sccache` version is 0.10.0 or higher * Rename `ACTIONS_CACHE_URL` to `ACTIONS_RESULTS_URL`
1 parent b400c27 commit 95ccba3

File tree

3 files changed

+8
-9
lines changed

3 files changed

+8
-9
lines changed

.github/workflows/build.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ jobs:
4545
uses: actions/github-script@v7
4646
with:
4747
script: |
48-
core.exportVariable('ACTIONS_CACHE_URL', process.env.ACTIONS_CACHE_URL || '');
48+
core.exportVariable('ACTIONS_RESULTS_URL', process.env.ACTIONS_RESULTS_URL || '');
4949
core.exportVariable('ACTIONS_RUNTIME_TOKEN', process.env.ACTIONS_RUNTIME_TOKEN || '');
5050
5151
- name: Extract TensorRT-LLM version
@@ -223,7 +223,7 @@ jobs:
223223
PLATFORM=${{ env.PLATFORM }}
224224
build_type=${{ env.BUILD_TYPE }}
225225
sccache_gha_enabled=on
226-
actions_cache_url=${{ env.ACTIONS_CACHE_URL }}
226+
actions_results_url=${{ env.ACTIONS_RESULTS_URL }}
227227
actions_runtime_token=${{ env.ACTIONS_RUNTIME_TOKEN }}
228228
target: ${{ env.TARGET }}
229229
tags: ${{ steps.meta.outputs.tags || steps.meta-pr.outputs.tags }}

Dockerfile_trtllm

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@ ARG cuda_base=12.8.0
33
ARG build_type=release
44
ARG ompi_version=4.1.7
55
ARG sccache_gha_enabled=off
6-
ARG actions_cache_url=""
6+
ARG actions_results_url=""
77
ARG actions_runtime_token=""
88

9-
109
# CUDA dependent dependencies resolver stage
1110
FROM nvidia/cuda:${cuda_base}-cudnn-devel-ubuntu24.04 AS cuda-builder
1211

@@ -66,15 +65,15 @@ WORKDIR /usr/src/text-generation-inference
6665
ARG cuda_arch_list
6766
ARG build_type
6867
ARG sccache_gha_enabled
69-
ARG actions_cache_url
68+
ARG actions_results_url
7069
ARG actions_runtime_token
7170

7271
# Install Rust
7372
ENV PATH="/root/.cargo/bin:$PATH"
7473
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- --default-toolchain 1.85.1 --profile minimal -y && \
7574
chmod -R a+w /root/.rustup && \
7675
chmod -R a+w /root/.cargo && \
77-
cargo install sccache --locked
76+
cargo install sccache --version ">=0.10.0" --locked
7877

7978
ENV LD_LIBRARY_PATH="/usr/local/mpi/lib:$LD_LIBRARY_PATH"
8079
ENV PKG_CONFIG_PATH="/usr/local/mpi/lib/pkgconfig"
@@ -85,7 +84,7 @@ ENV CUDA_ARCH_LIST=${cuda_arch_list}
8584

8685
# SCCACHE Specifics args - before finding a better, more generic, way...
8786
ENV SCCACHE_GHA_ENABLED=${sccache_gha_enabled}
88-
ENV ACTIONS_CACHE_URL=${actions_cache_url}
87+
ENV ACTIONS_RESULTS_URL=${actions_results_url}
8988
ENV ACTIONS_RUNTIME_TOKEN=${actions_runtime_token}
9089

9190
COPY Cargo.lock Cargo.lock

docs/source/backends/trtllm.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -163,15 +163,15 @@ WORKDIR /usr/src/text-generation-inference
163163
ARG cuda_arch_list
164164
ARG build_type
165165
ARG sccache_gha_enabled
166-
ARG actions_cache_url
166+
ARG actions_results_url
167167
ARG actions_runtime_token
168168

169169
# Install Rust
170170
ENV PATH="/root/.cargo/bin:$PATH"
171171
RUN curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | bash -s -- -y && \
172172
chmod -R a+w /root/.rustup && \
173173
chmod -R a+w /root/.cargo && \
174-
cargo install sccache --locked
174+
cargo install sccache --version ">=0.10.0" --locked
175175

176176
ENV LD_LIBRARY_PATH="/usr/local/mpi/lib:$LD_LIBRARY_PATH"
177177
ENV PKG_CONFIG_PATH="/usr/local/mpi/lib/pkgconfig"

0 commit comments

Comments
 (0)